More completing ros2-ification of perception tutorial#1
Open
130s wants to merge 1 commit intoRoboticsYY:ros2from
Open
More completing ros2-ification of perception tutorial#1130s wants to merge 1 commit intoRoboticsYY:ros2from
130s wants to merge 1 commit intoRoboticsYY:ros2from
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background of PR
I came from answers.ros.org#389233.
The repo
moveit_tutorialsseems to be designated for ros1 only, as there's https://github.com/ros-planning/moveit2_tutorials for ros2 version of moveit tutorial, where I started ros2-ification in moveit/moveit2_tutorials#700 (at the time of writing, I am stuck though, haven't been able to visualize octomap. To be clear, with the change in this PR, I still haven't visualized octomap yet).Issue
ros2branch ran into runtime problems so the process that starts withros2 launch moveit_tutorials obstacle_avoidance_demo.launchterminates early on.Open question
Whether merging this or not, I leave it up to you. However, the current state of ros2 branch of yours doesn't seem finished due to the issues I raised above, so might as well merge for the people who come here in the future.