Skip to content

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Jan 9, 2026

Proposed changes

Introduced on #6853

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1663

How to test or reproduce

  • Official iOS app shouldn't crash on open
  • Test Experimental as well

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Updated iOS build configuration and reorganized project dependencies to align with the current pod structure.

✏️ Tip: You can customize this high-level summary in your review settings.

@diegolmello diegolmello deployed to approve_e2e_testing January 9, 2026 13:39 — with GitHub Actions Active
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

Walkthrough

The iOS Xcode project file has been restructured to realign framework references, build phases, and configuration entries with a new pod/module architecture. Changes include swapping pod framework references, updating xcconfig entries, renaming build phases with new identifiers, and modifying shell script invocations.

Changes

Cohort / File(s) Summary
Pod Framework References
ios/RocketChatRN.xcodeproj/project.pbxproj
Swapped Pods_defaults_Rocket_Chat.framework for Pods_defaults_NotificationService.framework and Pods_defaults_RocketChatRN.framework; updated associated fileRef and buildFile entries.
XCBuild Configuration Updates
ios/RocketChatRN.xcodeproj/project.pbxproj
Updated xcconfig references across PBXFileReference and XCBuildConfiguration sections to align with new pod targets (Pods-defaults-Rocket.Chat.* and Pods-defaults-RocketChatRN.* variants).
Build Phases & Scripts
ios/RocketChatRN.xcodeproj/project.pbxproj
Renamed and reordered [CP] Check Pod Manifest.lock and [Expo] Configure project phases with new identifiers; replaced inline Expo configure scripts with simplified calls to expo-configure-project.sh; updated [CP] Copy Pods Resources and [CP] Embed Pods Frameworks phases to reference updated pod targets.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • PR #6744: Project file restructuring for react-native-mmkv migration with pod framework and xcconfig reference realignment.

Suggested reviewers

  • OtavioStasiak

Poem

🐇 Pods reorganized, frameworks aligned,
Build phases renamed with precision designed,
xcconfigs restructured, scripts made lean,
The cleanest Xcode project you've ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(iOS): official target missing build phases' directly and specifically describes the main change: restoring missing build phases in the official iOS target, which aligns with the raw summary's focus on build phase reorganization and the PR's objective to fix issues introduced in PR #6853.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix.official-build-ios

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello temporarily deployed to official_ios_build January 9, 2026 13:42 — with GitHub Actions Inactive
@diegolmello diegolmello requested a deployment to experimental_android_build January 9, 2026 13:42 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to official_android_build January 9, 2026 13:42 — with GitHub Actions Waiting
@diegolmello diegolmello temporarily deployed to experimental_ios_build January 9, 2026 13:42 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

iOS Build Available

Rocket.Chat Experimental 4.69.0.108023

@diegolmello diegolmello deployed to upload_official_ios January 9, 2026 14:16 — with GitHub Actions Active
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

iOS Build Available

Rocket.Chat 4.69.0.108024

Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diegolmello diegolmello merged commit ede2569 into develop Jan 9, 2026
37 of 43 checks passed
@diegolmello diegolmello deleted the fix.official-build-ios branch January 9, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants