-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(iOS): official target missing build phases #6905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe iOS Xcode project file has been restructured to realign framework references, build phases, and configuration entries with a new pod/module architecture. Changes include swapping pod framework references, updating xcconfig entries, renaming build phases with new identifiers, and modifying shell script invocations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
iOS Build Available Rocket.Chat Experimental 4.69.0.108023 |
|
iOS Build Available Rocket.Chat 4.69.0.108024 |
OtavioStasiak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Proposed changes
Introduced on #6853
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1663
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.