Skip to content

Conversation

@rodrigok
Copy link
Member

@rodrigok rodrigok commented Nov 17, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Adjusted Docker image size tracking to aggregate historical data on a daily basis instead of hourly, altering how measurements are consolidated over the 30-day tracking period.

@rodrigok rodrigok requested a review from a team as a code owner November 17, 2025 18:24
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

⚠️ No Changeset found

Latest commit: b7505d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok added this to the 7.13.0 milestone Nov 17, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

The Docker image size tracker's load-history step now groups historical data by day (timestamp[0:10]) instead of by minute/hour precision (timestamp[0:16]). This changes how multiple measurements within the same day are collapsed and which daily entries appear in the last 30-day window.

Changes

Cohort / File(s) Summary
Docker image size tracker configuration
\.github/actions/docker-image-size-tracker/action.yml
Modified historical data aggregation logic to group measurements by day instead of minute/hour precision, affecting which entries are retained in the 30-day tracking window

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Focus areas: Verify the timestamp slicing change ([0:16][0:10]) achieves the intended daily grouping behavior and doesn't break existing downstream logic that consumes the grouped data.

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo

Poem

🐰 A timestamp trimmed, a day's true form,
From minutes past to daily norm,
The tracker's breath, now measured wide,
Thirty days of pride collide! 📊✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(ci): group image size graph per day' clearly and concisely describes the main change: grouping image size graph data by day instead of minute/hour precision.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/ci-group-image-size-per-day

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ed544f8 and b7505d6.

📒 Files selected for processing (1)
  • .github/actions/docker-image-size-tracker/action.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: 🔎 Code Check / TypeScript
  • GitHub Check: 🔎 Code Check / Code Lint
  • GitHub Check: 🔨 Test Storybook / Test Storybook
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
.github/actions/docker-image-size-tracker/action.yml (1)

239-239: ✅ Correct jq pipeline for daily grouping.

The change correctly groups historical measurements by day instead of minute precision. The pipeline logic is sound: sort_by(.timestamp) ensures entries are chronologically ordered, group_by(.timestamp[0:10]) groups by date (YYYY-MM-DD), map(.[-1]) selects the last measurement per day, and .[-30:] retains the last 30 days. This aligns with the PR objective and maintains UTC consistency throughout the file (e.g., line 93 creates timestamps with date -u).

The comment on line 246 ("one per day") is already accurate for the new behavior.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 17, 2025
@ggazzo ggazzo merged commit d064a79 into develop Nov 17, 2025
24 checks passed
@ggazzo ggazzo deleted the chore/ci-group-image-size-per-day branch November 17, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants