-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: restore yarn config after install #37934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe pull request modifies GitHub Actions setup workflow and Yarn configuration. A new GitHub Actions step is added to restore the Yarn configuration file post-install when applicable, and the Yarn configuration is simplified by replacing explicit supported architectures with a single spec property. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/actions/setup-node/action.yml (1)
102-105: Consider adding a comment to explain the restoration step.The logic is sound: the step correctly restores
.yarnrc.ymlafter the install completes, preventing thesupportedArchitecturesmodification (from line 90) from being committed by release automation. However, adding a brief comment explaining why this restoration is necessary would help future maintainers understand this non-obvious step.📝 Suggested comment addition
+ # Restore .yarnrc.yml to prevent yarn config changes from being committed by automation - name: restore yarn config file if: inputs.install shell: bash run: git checkout -- .yarnrc.yml
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
.github/actions/setup-node/action.yml.yarnrc.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (2)
.yarnrc.yml (1)
13-13: LGTM! Configuration simplification looks good.The plugin configuration has been simplified from an explicit supportedArchitectures block to a single spec property. This represents the clean state that will be restored by the new CI step.
.github/actions/setup-node/action.yml (1)
102-105: The git checkout restoration step is correctly implemented. Verification confirms that.yarnrc.ymlis tracked in git and the restoration command succeeds as expected. The hard failure behavior on error is appropriate for CI, preventing incorrect state from being committed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #37934 +/- ##
=================================================
+ Coverage 71.73% 71.79% +0.06%
=================================================
Files 1453 1453
Lines 76689 76689
Branches 11133 11142 +9
=================================================
+ Hits 55013 55062 +49
+ Misses 21249 21196 -53
- Partials 427 431 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
Change introduced by #37841 is being unintentionally commited by our release automation.
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.