Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 22, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Change introduced by #37841 is being unintentionally commited by our release automation.

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Optimized GitHub Actions workflow to restore configuration files during installation
    • Simplified Yarn plugin configuration for improved build consistency

✏️ Tip: You can customize this high-level summary in your review settings.

@sampaiodiego sampaiodiego requested a review from a team as a code owner December 22, 2025 22:27
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: cda4ed0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Walkthrough

The pull request modifies GitHub Actions setup workflow and Yarn configuration. A new GitHub Actions step is added to restore the Yarn configuration file post-install when applicable, and the Yarn configuration is simplified by replacing explicit supported architectures with a single spec property.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Step
.github/actions/setup-node/action.yml
Adds a new step "restore yarn config file" after yarn install that executes git checkout -- .yarnrc.yml when inputs.install is true.
Yarn Configuration Simplification
.yarnrc.yml
Simplifies plugin configuration by replacing the explicit supportedArchitectures block with a single spec property, removing separate cpu/os/libc sections while maintaining plugin functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A rabbit hops with config in paw 🐰
Simplifying Yarn's setup law
One spec replaces many a file
Restoring configs with style
Changes smooth, no flaws to gnaw 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: restore yarn config after install' accurately summarizes the main change: adding a step to restore the Yarn configuration file after installation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-restore-yarn-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/actions/setup-node/action.yml (1)

102-105: Consider adding a comment to explain the restoration step.

The logic is sound: the step correctly restores .yarnrc.yml after the install completes, preventing the supportedArchitectures modification (from line 90) from being committed by release automation. However, adding a brief comment explaining why this restoration is necessary would help future maintainers understand this non-obvious step.

📝 Suggested comment addition
+    # Restore .yarnrc.yml to prevent yarn config changes from being committed by automation
     - name: restore yarn config file
       if: inputs.install
       shell: bash
       run: git checkout -- .yarnrc.yml
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3dc9e2b and cda4ed0.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .github/actions/setup-node/action.yml
  • .yarnrc.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (2)
.yarnrc.yml (1)

13-13: LGTM! Configuration simplification looks good.

The plugin configuration has been simplified from an explicit supportedArchitectures block to a single spec property. This represents the clean state that will be restored by the new CI step.

.github/actions/setup-node/action.yml (1)

102-105: The git checkout restoration step is correctly implemented. Verification confirms that .yarnrc.yml is tracked in git and the restoration command succeeds as expected. The hard failure behavior on error is appropriate for CI, preventing incorrect state from being committed.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.79%. Comparing base (3dc9e2b) to head (cda4ed0).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37934      +/-   ##
=================================================
+ Coverage          71.73%   71.79%   +0.06%     
=================================================
  Files               1453     1453              
  Lines              76689    76689              
  Branches           11133    11142       +9     
=================================================
+ Hits               55013    55062      +49     
+ Misses             21249    21196      -53     
- Partials             427      431       +4     
Flag Coverage Δ
unit 71.79% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.14.0 milestone Dec 22, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 22, 2025
@ggazzo ggazzo merged commit 32fce68 into release-8.0.0 Dec 22, 2025
38 of 40 checks passed
@ggazzo ggazzo deleted the chore-restore-yarn-config branch December 22, 2025 23:19
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants