Release 7.13.3 #38126
Release 7.13.3 #38126
Conversation
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
WalkthroughThis PR is a patch version release (7.13.3) with widespread version bumps across apps and packages, alongside CI workflow changes to handle artifact-based docker image distribution for fork PRs (download/load instead of publish) and a minor bugfix for async password validation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes The CI workflow logic changes (+100 lines across 3 files with conditional gating, artifact handling, and environment setup adjustments) require focused review (~15–20 min), while the extensive homogeneous version/changelog updates across ~50 files (~2 min per scan) are straightforward but numerous. A single one-line code bugfix requires minimal attention. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
📦 Docker Image Size Report📈 Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/09 21:22 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.16]
line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14]
line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.36]
line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.11]
Statistics (last 30 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Fri, 09 Jan 2026 21:22:44 GMT |
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Co-authored-by: Julio Araujo <julio.araujo@rocket.chat>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/ci.yml (2)
734-734: Same missing job reference intests-done.The
tests-donejob also depends on and checks the result oftest-ui-ee-watcher, which appears to have been removed. Both theneedsarray and the result check should be updated.Proposed fix
- needs: [checks, test-unit, test-api, test-ui, test-api-ee, test-ui-ee, test-ui-ee-watcher, test-federation-matrix] + needs: [checks, test-unit, test-api, test-ui, test-api-ee, test-ui-ee, test-federation-matrix]And remove lines 763-765:
- if [[ '${{ needs.test-ui-ee-watcher.result }}' != 'success' ]]; then - exit 1 - fiAlso applies to: 763-765
682-682: Remove or define thetest-ui-ee-watcherjob.The workflow references
test-ui-ee-watcheras a dependency in thereport-coveragejob (line 682) andtests-donejob (line 734), and checks its result on line 763. However, this job is not defined in the workflow. The workflow will fail when it attempts to wait for this non-existent job.
🤖 Fix all issues with AI agents
In @.github/actions/build-docker/action.yml:
- Around line 122-139: The jq query used to set DIGEST is malformed: replace the
`.["${{ inputs.service }}"].["containerimage.digest"]` expression with a valid
jq path such as `.["${{ inputs.service }}"]["containerimage.digest"]` (or use jq
with --arg and access via .[$svc]["containerimage.digest"]) so the nested key
with a dot in its name is accessed correctly when computing DIGEST.
In @.github/workflows/ci-test-e2e.yml:
- Around line 143-149: The workflow mixes actions/download-artifact@v6 and @v7;
standardize to @v7 everywhere (both the step named "Download Docker images" and
the earlier occurrence) so the workflow consistently requires Actions Runner >=
2.327.1; update the uses entries that reference actions/download-artifact
(including the one at the earlier step around line ~132 and the "Download Docker
images" step) to actions/download-artifact@v7.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/actions/build-docker/action.yml.github/workflows/ci-test-e2e.yml.github/workflows/ci.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 38068
File: apps/meteor/tests/data/apps/app-packages/README.md:14-16
Timestamp: 2026-01-08T15:03:45.071Z
Learning: For the RocketChat/Rocket.Chat repository, do not analyze or report formatting issues (such as hard tabs vs spaces, line breaks, etc.). The project relies on automated linting tools to enforce formatting standards.
Learnt from: cardoso
Repo: RocketChat/Rocket.Chat PR: 36942
File: apps/meteor/client/lib/e2ee/keychain.ts:148-156
Timestamp: 2025-10-16T21:09:51.816Z
Learning: In the RocketChat/Rocket.Chat repository, only platforms with native crypto.randomUUID() support are targeted, so fallback implementations for crypto.randomUUID() are not required in E2EE or cryptographic code.
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (10)
.github/actions/build-docker/action.yml (2)
141-165: LGTM!The artifact-based image handling for fork PRs is well-implemented. Saving only
amd64images aligns with the test execution requirements, and the 1-day retention is appropriate for ephemeral CI artifacts.
167-172: LGTM!The updated condition correctly gates manifest uploads to only occur when images are published, preventing errors in fork PR scenarios where the manifests directory wouldn't exist.
.github/workflows/ci-test-e2e.yml (2)
151-168: LGTM!The image loading logic is robust with proper file existence checks, cleanup after loading, and debugging output. The implementation correctly handles the fork PR workflow.
71-71: LGTM!The
-amd64suffix correctly aligns with the architecture-specific image tagging used in the build process..github/workflows/ci.yml (6)
628-654: LGTM!The Docker image download and load logic for federation tests mirrors the implementation in
ci-test-e2e.yml, maintaining consistency across fork PR handling. Note the@v7version inconsistency flagged earlier.
664-677: LGTM!The failure diagnostic steps are a valuable addition for debugging federation test issues, capturing logs from the key services (rc1-prebuilt, hs1, mongo).
315-328: LGTM!The separation of build (line 317) and publish (line 328) conditions is well-designed. This enables Docker images to be built for all PRs while restricting publishing to trusted contexts (same-repo PRs, releases, develop branch).
457-459: LGTM!The condition correctly restricts image size tracking to same-repo PRs where images are actually published to the registry.
590-590: LGTM!The runner change to
ubuntu-24.04(amd64) aligns with the amd64-specific Docker images used for federation tests.
659-660: LGTM!The
-amd64suffix onROCKETCHAT_IMAGEaligns with the image tagging convention, and the updated enterprise license addresses the expired license issue mentioned in the PR objectives.
| if [[ "${{ inputs.publish-image }}" == 'true' ]]; then | ||
| SERVICE_SUFFIX=${{ inputs.service == 'rocketchat' && inputs.type == 'coverage' && (github.event_name == 'release' || github.ref == 'refs/heads/develop') && '-cov' || '' }} | ||
| mkdir -p /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }} | ||
| mkdir -p /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }} | ||
| # Get digest and image info | ||
| DIGEST=$(jq -r '.["${{ inputs.service }}"].["containerimage.digest"]' "/tmp/meta.json") | ||
| IMAGE_NO_TAG=$(echo "$IMAGE" | sed 's/:.*$//') | ||
| FULL_IMAGE="${IMAGE_NO_TAG}@${DIGEST}" | ||
| # Get digest and image info | ||
| DIGEST=$(jq -r '.["${{ inputs.service }}"].["containerimage.digest"]' "/tmp/meta.json") | ||
| IMAGE_NO_TAG=$(echo "$IMAGE" | sed 's/:.*$//') | ||
| FULL_IMAGE="${IMAGE_NO_TAG}@${DIGEST}" | ||
| echo "Inspecting image: $FULL_IMAGE" | ||
| echo "Inspecting image: $FULL_IMAGE" | ||
| # Inspect the image and save complete manifest with sizes (using -v for verbose) | ||
| docker manifest inspect -v "$FULL_IMAGE" > "/tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | ||
| echo "Saved manifest to /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | ||
| cat "/tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | jq '.' | ||
| fi |
There was a problem hiding this comment.
Verify jq path syntax for nested keys with special characters.
The jq query on line 128 uses a nested bracket syntax .["${{ inputs.service }}"].["containerimage.digest"] which has an extra period before the second bracket. This may cause issues.
Proposed fix
- DIGEST=$(jq -r '.["${{ inputs.service }}"].["containerimage.digest"]' "/tmp/meta.json")
+ DIGEST=$(jq -r '.["${{ inputs.service }}"]["containerimage.digest"]' "/tmp/meta.json")📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if [[ "${{ inputs.publish-image }}" == 'true' ]]; then | |
| SERVICE_SUFFIX=${{ inputs.service == 'rocketchat' && inputs.type == 'coverage' && (github.event_name == 'release' || github.ref == 'refs/heads/develop') && '-cov' || '' }} | |
| mkdir -p /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }} | |
| mkdir -p /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }} | |
| # Get digest and image info | |
| DIGEST=$(jq -r '.["${{ inputs.service }}"].["containerimage.digest"]' "/tmp/meta.json") | |
| IMAGE_NO_TAG=$(echo "$IMAGE" | sed 's/:.*$//') | |
| FULL_IMAGE="${IMAGE_NO_TAG}@${DIGEST}" | |
| # Get digest and image info | |
| DIGEST=$(jq -r '.["${{ inputs.service }}"].["containerimage.digest"]' "/tmp/meta.json") | |
| IMAGE_NO_TAG=$(echo "$IMAGE" | sed 's/:.*$//') | |
| FULL_IMAGE="${IMAGE_NO_TAG}@${DIGEST}" | |
| echo "Inspecting image: $FULL_IMAGE" | |
| echo "Inspecting image: $FULL_IMAGE" | |
| # Inspect the image and save complete manifest with sizes (using -v for verbose) | |
| docker manifest inspect -v "$FULL_IMAGE" > "/tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | |
| echo "Saved manifest to /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | |
| cat "/tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | jq '.' | |
| fi | |
| if [[ "${{ inputs.publish-image }}" == 'true' ]]; then | |
| SERVICE_SUFFIX=${{ inputs.service == 'rocketchat' && inputs.type == 'coverage' && (github.event_name == 'release' || github.ref == 'refs/heads/develop') && '-cov' || '' }} | |
| mkdir -p /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }} | |
| # Get digest and image info | |
| DIGEST=$(jq -r '.["${{ inputs.service }}"]["containerimage.digest"]' "/tmp/meta.json") | |
| IMAGE_NO_TAG=$(echo "$IMAGE" | sed 's/:.*$//') | |
| FULL_IMAGE="${IMAGE_NO_TAG}@${DIGEST}" | |
| echo "Inspecting image: $FULL_IMAGE" | |
| # Inspect the image and save complete manifest with sizes (using -v for verbose) | |
| docker manifest inspect -v "$FULL_IMAGE" > "/tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | |
| echo "Saved manifest to /tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | |
| cat "/tmp/manifests/${{ inputs.service }}${SERVICE_SUFFIX}/${{ inputs.arch }}/manifest.json" | jq '.' | |
| fi |
🤖 Prompt for AI Agents
In @.github/actions/build-docker/action.yml around lines 122 - 139, The jq query
used to set DIGEST is malformed: replace the `.["${{ inputs.service
}}"].["containerimage.digest"]` expression with a valid jq path such as `.["${{
inputs.service }}"]["containerimage.digest"]` (or use jq with --arg and access
via .[$svc]["containerimage.digest"]) so the nested key with a dot in its name
is accessed correctly when computing DIGEST.
| - name: Download Docker images | ||
| uses: actions/download-artifact@v7 | ||
| if: github.event.pull_request.head.repo.full_name != github.repository && github.event_name != 'release' && github.ref != 'refs/heads/develop' | ||
| with: | ||
| CR_USER: ${{ secrets.CR_USER }} | ||
| CR_PAT: ${{ secrets.CR_PAT }} | ||
| # the same reason we need to rebuild the docker image at this point is the reason we dont want to publish it | ||
| publish-image: false | ||
| arch: amd64 | ||
| service: 'rocketchat' | ||
| type: 'coverage' | ||
| pattern: ${{ inputs.release == 'ce' && 'docker-image-rocketchat-amd64-coverage' || 'docker-image-*-amd64-coverage' }} | ||
| path: /tmp/docker-images | ||
| merge-multiple: true |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's check the workflow file and locate all download-artifact usages
cd .github/workflows && cat -n ci-test-e2e.yml | grep -A 2 -B 2 "download-artifact"Repository: RocketChat/Rocket.Chat
Length of output: 561
🌐 Web query:
actions/download-artifact latest version GitHub
💡 Result:
Latest stable version: actions/download-artifact@v4. [1][2]
Notes: v4 is the current GA release (not cross-compatible with v3); v3 was deprecated for GitHub Actions runners (GHES may still require v3). [1][2]
🌐 Web query:
actions/download-artifact v6 v7 release notes GitHub
💡 Result:
Summary of release notes — actions/download-artifact
- v6.0.0 — notes: bump of @actions/artifact, README/extraction updates; treated Node.js v24 support as a (breaking) change. [1]
- v7.0.0 — notes: defaults to Node.js 24 (runs.using: node24), requires Actions Runner >= 2.327.1; GHES guidance updated; fixes including updating @actions/artifact to address Node.js 24 punycode deprecation. [2]
Sources:
[1] actions/download-artifact v6.0.0 release notes.
[2] actions/download-artifact v7.0.0 release notes.
🌐 Web query:
download-artifact action version history releases
💡 Result:
Brief summary — actions/download-artifact version history & release notes:
- v4: Announced GA Dec 14, 2023 — major rewrite (much faster, job-scoped artifacts, new inputs like pattern/github-token/run-id; v4 is not cross‑compatible with v3+). [1][4]
- v1 & v2: Marked for deprecation (will stop working after June 30, 2024). [2]
- v3: Marked for deprecation (will stop working after January 30, 2025). [3]
Notes: v4+ is not yet supported on some GHES releases; artifacts uploaded with v3 or earlier cannot be downloaded with v4. See the v4 migration docs/README for inputs, breaking changes and examples. [1][4]
Sources:
[1] GitHub Changelog — Artifacts v4 GA (Dec 14, 2023).
[2] GitHub Changelog — Deprecation notice: v1 and v2 (Feb 13, 2024).
[3] GitHub Changelog — Deprecation notice: v3 (Apr 16, 2024).
[4] actions/download-artifact README / marketplace/docs (v4 details and breaking changes).
Inconsistent action versions: use actions/download-artifact@v7 consistently.
Line 132 uses actions/download-artifact@v6 while line 144 uses @v7. Both versions are valid, but v7 requires Actions Runner >= 2.327.1. Standardize on v7 across this workflow to avoid version drift and ensure consistent runner requirements.
🤖 Prompt for AI Agents
In @.github/workflows/ci-test-e2e.yml around lines 143 - 149, The workflow mixes
actions/download-artifact@v6 and @v7; standardize to @v7 everywhere (both the
step named "Download Docker images" and the earlier occurrence) so the workflow
consistently requires Actions Runner >= 2.327.1; update the uses entries that
reference actions/download-artifact (including the one at the earlier step
around line ~132 and the "Download Docker images" step) to
actions/download-artifact@v7.
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Julio Araujo <julio.araujo@rocket.chat>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/ci.yml:
- Around line 657-684: The "Download Docker images" workflow step currently
references actions/download-artifact@v7; change it to
actions/download-artifact@v6 to match other download-artifact steps for
consistency—update the uses value in the step named "Download Docker images"
(the step that sets pattern: 'docker-image-rocketchat-amd64-coverage' and path:
/tmp/docker-images) from @v7 to @v6.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.changeset/stale-shoes-serve.md.github/workflows/ci.ymlee/apps/account-service/src/lib/loginViaUsername.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
ee/apps/account-service/src/lib/loginViaUsername.ts
🧠 Learnings (1)
📓 Common learnings
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 38068
File: apps/meteor/tests/data/apps/app-packages/README.md:14-16
Timestamp: 2026-01-08T15:03:59.621Z
Learning: For the RocketChat/Rocket.Chat repository, do not analyze or report formatting issues (such as hard tabs vs spaces, line breaks, etc.). The project relies on automated linting tools to enforce formatting standards.
Learnt from: cardoso
Repo: RocketChat/Rocket.Chat PR: 36942
File: apps/meteor/client/lib/e2ee/keychain.ts:148-156
Timestamp: 2025-10-16T21:09:51.816Z
Learning: In the RocketChat/Rocket.Chat repository, only platforms with native crypto.randomUUID() support are targeted, so fallback implementations for crypto.randomUUID() are not required in E2EE or cryptographic code.
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
🧬 Code graph analysis (1)
ee/apps/account-service/src/lib/loginViaUsername.ts (2)
apps/meteor/client/startup/iframeCommands.ts (1)
user(80-89)apps/meteor/tests/e2e/page-objects/fragments/e2ee.ts (1)
password(51-53)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CodeQL-Build
🔇 Additional comments (6)
.changeset/stale-shoes-serve.md (1)
1-5: LGTM!The changeset correctly documents a patch-level fix for the account-service. The description accurately reflects the issue being addressed (async operations not being awaited).
ee/apps/account-service/src/lib/loginViaUsername.ts (1)
18-21: Critical security fix correctly applied.Adding
awaittovalidatePasswordresolves a serious authentication bypass bug. Withoutawait, the Promise object itself (always truthy) was being evaluated instead of the actual validation result, allowing any password to pass validation when a bcrypt hash existed.The parentheses around
(await validatePassword(...))correctly handle operator precedence with&&..github/workflows/ci.yml (4)
315-373: LGTM on build-docker gating refactor.The separation of the
ifcondition (for running the step) from thepublish-imageflag (for controlling registry push) is a clean approach. This enables fork PRs to build images as artifacts without requiring registry credentials, while the main repo PRs, releases, and develop branch pushes will publish to the registry.
457-465: LGTM on image size tracking gating.Appropriately limits tracking to PRs from the main repository where images are actually published to the registry.
685-691: LGTM on federation test environment setup.The
-amd64suffix inROCKETCHAT_IMAGEcorrectly aligns with theubuntu-24.04(x86) runner and the download artifact pattern. The test will use the appropriate architecture-specific image.
693-706: Verify the service names exist in docker-compose.test.ymlThe failure logging steps for
rc1-prebuilt,hs1, andmongowill aid debugging federation test failures. However, confirm that these service names are actually defined inee/packages/federation-matrix/docker-compose.test.yml, as the docker commands will fail silently if the services don't exist.
| # Download Docker images from build artifacts | ||
| - name: Download Docker images | ||
| uses: actions/download-artifact@v7 | ||
| if: github.event.pull_request.head.repo.full_name != github.repository && github.event_name != 'release' && github.ref != 'refs/heads/develop' | ||
| with: | ||
| pattern: 'docker-image-rocketchat-amd64-coverage' | ||
| path: /tmp/docker-images | ||
| merge-multiple: true | ||
|
|
||
| # Load Docker images | ||
| - name: Load Docker images | ||
| if: github.event.pull_request.head.repo.full_name != github.repository && github.event_name != 'release' && github.ref != 'refs/heads/develop' | ||
| shell: bash | ||
| run: | | ||
| set -o xtrace | ||
| # Load all downloaded images | ||
| for image_file in /tmp/docker-images/*.tar; do | ||
| if [ -f "$image_file" ]; then | ||
| echo "Loading image from $image_file" | ||
| docker load -i "$image_file" | ||
| rm "$image_file" | ||
| fi | ||
| done | ||
| # List loaded images | ||
| docker images | ||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check all download-artifact usages with their versions in ci.yml
rg -n 'actions/download-artifact@' .github/workflows/ci.ymlRepository: RocketChat/Rocket.Chat
Length of output: 394
🏁 Script executed:
# Check the build-docker action for upload-artifact patterns
rg -n -C3 'upload-artifact|artifact.*name' .github/actions/build-docker/action.ymlRepository: RocketChat/Rocket.Chat
Length of output: 691
Align actions/download-artifact version to v6 for consistency.
Line 659 uses actions/download-artifact@v7, while all other download-artifact steps in this workflow (lines 304, 403, 635, 722, 817, 888) use @v6. Update line 659 to use @v6 to maintain consistency across the workflow.
🤖 Prompt for AI Agents
In @.github/workflows/ci.yml around lines 657 - 684, The "Download Docker
images" workflow step currently references actions/download-artifact@v7; change
it to actions/download-artifact@v6 to match other download-artifact steps for
consistency—update the uses value in the step named "Download Docker images"
(the step that sets pattern: 'docker-image-rocketchat-amd64-coverage' and path:
/tmp/docker-images) from @v7 to @v6.
[no ci]
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @apps/meteor/CHANGELOG.md:
- Around line 7-9: Remove the duplicate changelog entry "Bump
@rocket.chat/meteor version." so only one instance remains in the file; locate
the repeated line string and delete one of the occurrences, then ensure
surrounding spacing/formatting is preserved (no extra blank lines) and run a
quick check that the file contains the single intended entry.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (84)
apps/meteor/CHANGELOG.mdapps/meteor/app/utils/rocketchat.infoapps/meteor/ee/server/services/CHANGELOG.mdapps/meteor/ee/server/services/package.jsonapps/meteor/package.jsonapps/uikit-playground/CHANGELOG.mdapps/uikit-playground/package.jsonee/apps/account-service/CHANGELOG.mdee/apps/account-service/package.jsonee/apps/authorization-service/CHANGELOG.mdee/apps/authorization-service/package.jsonee/apps/ddp-streamer/CHANGELOG.mdee/apps/ddp-streamer/package.jsonee/apps/omnichannel-transcript/CHANGELOG.mdee/apps/omnichannel-transcript/package.jsonee/apps/presence-service/CHANGELOG.mdee/apps/presence-service/package.jsonee/apps/queue-worker/CHANGELOG.mdee/apps/queue-worker/package.jsonee/apps/stream-hub-service/CHANGELOG.mdee/apps/stream-hub-service/package.jsonee/packages/federation-matrix/CHANGELOG.mdee/packages/federation-matrix/package.jsonee/packages/license/CHANGELOG.mdee/packages/license/package.jsonee/packages/media-calls/CHANGELOG.mdee/packages/media-calls/package.jsonee/packages/network-broker/CHANGELOG.mdee/packages/network-broker/package.jsonee/packages/omni-core-ee/CHANGELOG.mdee/packages/omni-core-ee/package.jsonee/packages/omnichannel-services/CHANGELOG.mdee/packages/omnichannel-services/package.jsonee/packages/pdf-worker/CHANGELOG.mdee/packages/pdf-worker/package.jsonee/packages/presence/CHANGELOG.mdee/packages/presence/package.jsonpackage.jsonpackages/api-client/CHANGELOG.mdpackages/api-client/package.jsonpackages/apps/CHANGELOG.mdpackages/apps/package.jsonpackages/core-services/CHANGELOG.mdpackages/core-services/package.jsonpackages/core-typings/CHANGELOG.mdpackages/core-typings/package.jsonpackages/cron/CHANGELOG.mdpackages/cron/package.jsonpackages/ddp-client/CHANGELOG.mdpackages/ddp-client/package.jsonpackages/freeswitch/CHANGELOG.mdpackages/freeswitch/package.jsonpackages/fuselage-ui-kit/CHANGELOG.mdpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/CHANGELOG.mdpackages/gazzodown/package.jsonpackages/http-router/CHANGELOG.mdpackages/http-router/package.jsonpackages/instance-status/CHANGELOG.mdpackages/instance-status/package.jsonpackages/livechat/CHANGELOG.mdpackages/livechat/package.jsonpackages/mock-providers/CHANGELOG.mdpackages/mock-providers/package.jsonpackages/model-typings/CHANGELOG.mdpackages/model-typings/package.jsonpackages/models/CHANGELOG.mdpackages/models/package.jsonpackages/omni-core/CHANGELOG.mdpackages/omni-core/package.jsonpackages/rest-typings/CHANGELOG.mdpackages/rest-typings/package.jsonpackages/ui-avatar/CHANGELOG.mdpackages/ui-avatar/package.jsonpackages/ui-client/CHANGELOG.mdpackages/ui-client/package.jsonpackages/ui-contexts/CHANGELOG.mdpackages/ui-contexts/package.jsonpackages/ui-video-conf/CHANGELOG.mdpackages/ui-video-conf/package.jsonpackages/ui-voip/CHANGELOG.mdpackages/ui-voip/package.jsonpackages/web-ui-registration/CHANGELOG.mdpackages/web-ui-registration/package.json
✅ Files skipped from review due to trivial changes (40)
- packages/ui-avatar/package.json
- ee/packages/federation-matrix/CHANGELOG.md
- packages/gazzodown/CHANGELOG.md
- packages/core-typings/package.json
- packages/model-typings/CHANGELOG.md
- ee/packages/network-broker/package.json
- packages/cron/CHANGELOG.md
- packages/freeswitch/CHANGELOG.md
- ee/apps/stream-hub-service/CHANGELOG.md
- packages/web-ui-registration/CHANGELOG.md
- ee/packages/license/package.json
- packages/rest-typings/package.json
- packages/core-services/CHANGELOG.md
- ee/apps/account-service/CHANGELOG.md
- packages/ui-video-conf/package.json
- ee/apps/ddp-streamer/CHANGELOG.md
- ee/packages/presence/CHANGELOG.md
- packages/rest-typings/CHANGELOG.md
- packages/fuselage-ui-kit/package.json
- apps/uikit-playground/package.json
- ee/packages/media-calls/package.json
- packages/core-typings/CHANGELOG.md
- ee/apps/queue-worker/CHANGELOG.md
- ee/apps/omnichannel-transcript/CHANGELOG.md
- packages/ui-voip/CHANGELOG.md
- packages/models/CHANGELOG.md
- ee/apps/stream-hub-service/package.json
- packages/omni-core/CHANGELOG.md
- packages/ui-voip/package.json
- packages/livechat/package.json
- packages/ui-client/package.json
- packages/mock-providers/package.json
- ee/apps/authorization-service/package.json
- package.json
- ee/apps/presence-service/package.json
- ee/apps/account-service/package.json
- packages/instance-status/package.json
- packages/ddp-client/package.json
- packages/omni-core/package.json
- ee/packages/presence/package.json
🧰 Additional context used
🧠 Learnings (9)
📓 Common learnings
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 38068
File: apps/meteor/tests/data/apps/app-packages/README.md:14-16
Timestamp: 2026-01-08T15:03:59.621Z
Learning: For the RocketChat/Rocket.Chat repository, do not analyze or report formatting issues (such as hard tabs vs spaces, line breaks, etc.). The project relies on automated linting tools to enforce formatting standards.
Learnt from: cardoso
Repo: RocketChat/Rocket.Chat PR: 36942
File: apps/meteor/client/lib/e2ee/keychain.ts:148-156
Timestamp: 2025-10-16T21:09:51.816Z
Learning: In the RocketChat/Rocket.Chat repository, only platforms with native crypto.randomUUID() support are targeted, so fallback implementations for crypto.randomUUID() are not required in E2EE or cryptographic code.
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
📚 Learning: 2025-12-10T21:00:54.909Z
Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.
Applied to files:
packages/models/package.jsonpackages/api-client/package.json
📚 Learning: 2025-10-28T16:53:42.761Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.
Applied to files:
ee/packages/federation-matrix/package.json
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
Applied to files:
ee/packages/federation-matrix/package.json
📚 Learning: 2025-11-05T21:04:35.787Z
Learnt from: sampaiodiego
Repo: RocketChat/Rocket.Chat PR: 37357
File: ee/packages/federation-matrix/src/setup.ts:103-120
Timestamp: 2025-11-05T21:04:35.787Z
Learning: In Rocket.Chat's federation-matrix setup (ee/packages/federation-matrix/src/setup.ts and apps/meteor/ee/server/startup/federation.ts), configureFederationMatrixSettings does not need to be called before setupFederationMatrix. The SDK's init() establishes infrastructure (database, event handlers, APIs) first, and the configuration can be applied later via settings watchers before actual federation events are processed. The config only matters when events actually occur, at which point all infrastructure is already configured.
Applied to files:
ee/packages/federation-matrix/package.json
📚 Learning: 2025-11-19T12:32:29.696Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
Applied to files:
apps/meteor/CHANGELOG.mdpackages/ui-contexts/package.json
📚 Learning: 2026-01-08T15:03:59.621Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 38068
File: apps/meteor/tests/data/apps/app-packages/README.md:14-16
Timestamp: 2026-01-08T15:03:59.621Z
Learning: For the RocketChat/Rocket.Chat repository, do not analyze or report formatting issues (such as hard tabs vs spaces, line breaks, etc.). The project relies on automated linting tools to enforce formatting standards.
Applied to files:
apps/meteor/CHANGELOG.md
📚 Learning: 2025-11-19T18:20:07.720Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37419
File: packages/i18n/src/locales/en.i18n.json:918-921
Timestamp: 2025-11-19T18:20:07.720Z
Learning: Repo: RocketChat/Rocket.Chat — i18n/formatting
Learning: This repository uses a custom message formatting parser in UI blocks/messages; do not assume standard Markdown rules. For keys like Call_ended_bold, Call_not_answered_bold, Call_failed_bold, and Call_transferred_bold in packages/i18n/src/locales/en.i18n.json, retain the existing single-asterisk emphasis unless maintainers request otherwise.
Applied to files:
apps/meteor/CHANGELOG.md
📚 Learning: 2025-11-10T19:06:20.146Z
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.
Applied to files:
apps/meteor/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: 📦 Build Packages
🔇 Additional comments (43)
ee/apps/queue-worker/package.json (1)
4-4: LGTM!Standard version bump to 0.4.47 as part of the 7.13.3 patch release. Consistent with the coordinated version updates across other EE app packages.
apps/meteor/app/utils/rocketchat.info (1)
1-3: LGTM!The version bump to
7.13.3is consistent with the release PR objectives and the coordinated version updates across other packages.packages/cron/package.json (1)
3-3: LGTM!Version bump to 0.1.47 aligns with the 7.13.3 release and the coordinated dependency updates across the monorepo. Workspace references ensure consistent internal package resolution.
ee/apps/omnichannel-transcript/package.json (1)
4-4: LGTM!Standard patch version bump for the 7.13.3 release. No functional changes to review.
ee/packages/federation-matrix/package.json (1)
3-3: LGTM!Version bump to
0.0.9aligns with the release 7.13.3 objectives and coordinated package updates.packages/freeswitch/package.json (1)
3-3: LGTM!The version bump to 1.2.34 is consistent with the 7.13.3 release and the corresponding changelog update.
apps/meteor/package.json (1)
4-4: LGTM!The patch version bump from
7.13.2to7.13.3is correct and aligns with the release objectives. The workspace dependencies will automatically resolve to their corresponding updated versions as part of this coordinated release.ee/packages/omni-core-ee/package.json (1)
3-3: LGTM!Version bump to 0.0.12 is consistent with the release 7.13.3 and aligns with the changelog entry.
ee/packages/omni-core-ee/CHANGELOG.md (1)
3-12: LGTM!The changelog entry for 0.0.12 follows the established format and correctly documents the updated dependencies. The version is consistent with the package.json bump.
ee/packages/pdf-worker/CHANGELOG.md (1)
3-10: LGTM!The changelog entry for version 0.3.26 follows the established format and correctly documents the dependency update to
@rocket.chat/core-typings@7.13.3.ee/packages/pdf-worker/package.json (1)
3-3: LGTM!Version bump to
0.3.26is consistent with the changelog entry and the release notes.packages/api-client/package.json (1)
1-37: LGTM!The version bump to 0.2.47 is consistent with the changelog entry and aligns with the 7.13.3 release. Workspace dependencies will correctly resolve to the updated
@rocket.chat/core-typings@7.13.3and@rocket.chat/rest-typings@7.13.3.packages/api-client/CHANGELOG.md (1)
3-12: LGTM!The changelog entry for 0.2.47 follows the established format and correctly documents the dependency updates to
@rocket.chat/core-typings@7.13.3and@rocket.chat/rest-typings@7.13.3, consistent with the 7.13.3 release.ee/apps/ddp-streamer/package.json (1)
1-69: LGTM!The version bump from 0.3.46 to 0.3.47 is consistent with the 7.13.3 release. The package structure and workspace dependencies are properly configured.
packages/ddp-client/CHANGELOG.md (1)
3-13: LGTM!The new changelog entry for version 0.3.47 follows the established format and correctly documents the updated dependencies for the 7.13.3 release.
apps/meteor/ee/server/services/package.json (1)
4-4: LGTM!Version bump from 2.0.37 to 2.0.38 is consistent with the release and aligns with the corresponding changelog entry.
apps/meteor/ee/server/services/CHANGELOG.md (1)
3-15: LGTM!Changelog entry for version 2.0.38 follows the established format and correctly documents the updated dependencies for the 7.13.3 release.
ee/packages/omnichannel-services/package.json (1)
1-55: LGTM!Version bump to 0.3.44 is consistent with the release objectives and the corresponding CHANGELOG.md entry.
ee/packages/omnichannel-services/CHANGELOG.md (1)
3-16: LGTM!The new changelog entry for version 0.3.44 is properly formatted and lists updated dependencies that align with the release objectives. The empty brackets in the summary tag follow the established pattern used throughout this changelog for dependency-only updates.
packages/instance-status/CHANGELOG.md (1)
3-10: LGTM!The changelog entry correctly documents the patch version bump to 0.1.47 and the updated dependency on @rocket.chat/models@1.8.3. The format is consistent with the existing changelog structure.
packages/model-typings/package.json (1)
3-3: LGTM!Version bump to 1.9.3 is consistent with the release 7.13.3 objectives.
packages/apps/package.json (1)
3-3: LGTM!Version bump to 0.5.26 aligns with the release 7.13.3 patch changes.
packages/apps/CHANGELOG.md (1)
3-11: LGTM!Changelog entry for version 0.5.26 correctly documents the dependency updates and follows the established format.
ee/packages/network-broker/CHANGELOG.md (1)
3-10: LGTM!Changelog entry for version 0.2.26 correctly documents the core-services dependency update.
packages/models/package.json (1)
3-3: LGTM!Version bump to 1.8.3 is consistent with the release 7.13.3 objectives.
packages/http-router/package.json (1)
3-3: LGTM!Version bump to
7.9.14aligns with the release 7.13.3 objectives.packages/core-services/package.json (1)
3-3: LGTM!Version bump to
0.11.3aligns with the release 7.13.3 objectives.packages/ui-contexts/package.json (1)
3-3: Version bump looks correct.The version update to 25.0.3 aligns with the release 7.13.3 objectives and is consistent with other UI-related packages in this PR.
packages/gazzodown/package.json (1)
3-3: Version bump looks correct.The version update to 25.0.3 is consistent with the patch release and aligns with other UI packages in this PR.
packages/ui-avatar/CHANGELOG.md (1)
3-11: Changelog entry looks correct.The new 21.0.3 entry follows the established format and correctly references the updated dependency @rocket.chat/ui-contexts@25.0.3.
packages/ui-video-conf/CHANGELOG.md (1)
3-12: Changelog entry looks correct.The new 25.0.3 entry follows the established format and correctly references the updated dependencies @rocket.chat/ui-avatar@21.0.3 and @rocket.chat/ui-contexts@25.0.3.
packages/ui-client/CHANGELOG.md (1)
3-12: Changelog entry looks correct.The new 25.0.3 entry follows the established format and correctly references the updated dependencies @rocket.chat/ui-avatar@21.0.3 and @rocket.chat/ui-contexts@25.0.3.
packages/web-ui-registration/package.json (1)
3-3: LGTM!Version bump to 25.0.3 and corresponding peer dependency update for
@rocket.chat/ui-contextsare consistent with the coordinated release.Also applies to: 66-66
packages/ui-contexts/CHANGELOG.md (1)
3-13: LGTM!Changelog entry for version 25.0.3 is properly formatted and lists the expected dependency updates for the 7.13.3 release.
packages/fuselage-ui-kit/CHANGELOG.md (1)
3-15: LGTM!Changelog entry for version 25.0.3 is properly formatted and lists the expected dependency updates consistent with the coordinated release.
packages/mock-providers/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is correctly formatted.The changelog entry for version 0.4.7 follows the established format and correctly documents the dependency update to
@rocket.chat/ui-contexts@25.0.3, which aligns with the PR objectives for the 7.13.3 release.ee/packages/license/CHANGELOG.md (1)
3-10: LGTM! Standard changelog update for release 7.13.3The new version entry follows the established format and correctly documents the dependency update to
@rocket.chat/core-typings@7.13.3, consistent with this patch release.ee/packages/media-calls/CHANGELOG.md (1)
3-12: LGTM! Changelog entry is correctly formatted.The new version 0.1.3 changelog entry follows the established format and correctly documents the patch-level dependency updates.
packages/http-router/CHANGELOG.md (1)
3-12: LGTM! Changelog entry is well-formed.The version 7.9.14 changelog entry correctly documents the dependency updates to @rocket.chat/core-typings@7.13.3 and @rocket.chat/rest-typings@7.13.3, and follows the established format consistently used throughout this file.
apps/uikit-playground/CHANGELOG.md (1)
3-14: LGTM! Standard changelog entry for patch release.The changelog entry correctly documents version 0.7.3 with updated dependency versions that align with the PR objectives. The format is consistent with existing entries.
packages/livechat/CHANGELOG.md (1)
3-11: LGTM! Changelog entry is properly formatted.The new version entry for 1.23.18 correctly documents the dependency update to @rocket.chat/gazzodown@25.0.3 and follows the established changelog format consistently.
ee/apps/presence-service/CHANGELOG.md (1)
3-16: LGTM! Changelog entry is well-formed.The new version entry follows the established format and properly documents the dependency updates for release 7.13.3. The structure is consistent with previous patch releases in this changelog.
ee/apps/authorization-service/CHANGELOG.md (1)
3-16: LGTM! Standard release changelog entry.The changelog entry for version 0.4.47 is correctly formatted and documents the dependency updates for the 7.13.3 release. The version bumps are consistent across all packages.
| - Bump @rocket.chat/meteor version. | ||
|
|
||
| - Bump @rocket.chat/meteor version. |
There was a problem hiding this comment.
Remove duplicate changelog entry.
The changelog entry "Bump @rocket.chat/meteor version." appears twice (lines 7 and 9), which is redundant. Remove one of these duplicate entries.
📝 Proposed fix
### Patch Changes
- Bump @rocket.chat/meteor version.
-
-- Bump @rocket.chat/meteor version.
- <details><summary>Updated dependencies []:</summary>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Bump @rocket.chat/meteor version. | |
| - Bump @rocket.chat/meteor version. | |
| ### Patch Changes | |
| - Bump @rocket.chat/meteor version. | |
| - <details><summary>Updated dependencies []:</summary> |
🤖 Prompt for AI Agents
In @apps/meteor/CHANGELOG.md around lines 7 - 9, Remove the duplicate changelog
entry "Bump @rocket.chat/meteor version." so only one instance remains in the
file; locate the repeated line string and delete one of the occurrences, then
ensure surrounding spacing/formatting is preserved (no extra blank lines) and
run a quick check that the file contains the single intended entry.
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.
You can see below a preview of the release change log:
7.13.3
Engine versions
22.16.01.43.55, 6, 7, 81.58.0Patch Changes
Bump @rocket.chat/meteor version.
Updated dependencies []: