Release 8.1.0 #38281
Release 8.1.0 #38281
Conversation
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
…38106) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
…e call (#37616) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
Co-authored-by: Julio Araujo <193944692+julio-rocketchat@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 822a896 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Important Review skippedToo many files! 146 files out of 296 files are above the max files limit of 150. You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 952 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/ci.yml">
<violation number="1" location=".github/workflows/ci.yml:459">
P2: This new condition disables the image size tracker on develop pushes because `github.event.pull_request` is undefined outside PR events. If the job is meant to run on develop (as the job-level condition indicates), update the step condition to allow non-PR events.</violation>
</file>
<file name="apps/meteor/app/api/server/lib/MultipartUploadHandler.ts">
<violation number="1" location="apps/meteor/app/api/server/lib/MultipartUploadHandler.ts:193">
P2: Handle `IncomingMessage` stream errors before piping to busboy so aborted uploads reject cleanly instead of emitting an unhandled stream error.</violation>
<violation number="2" location="apps/meteor/app/api/server/lib/MultipartUploadHandler.ts:199">
P2: Attach an error handler to the Node stream produced by `Readable.fromWeb()` before piping so stream errors reject the upload instead of crashing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| - name: Track Docker image sizes | ||
| uses: ./.github/actions/docker-image-size-tracker | ||
| if: github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository |
There was a problem hiding this comment.
P2: This new condition disables the image size tracker on develop pushes because github.event.pull_request is undefined outside PR events. If the job is meant to run on develop (as the job-level condition indicates), update the step condition to allow non-PR events.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/ci.yml, line 459:
<comment>This new condition disables the image size tracker on develop pushes because `github.event.pull_request` is undefined outside PR events. If the job is meant to run on develop (as the job-level condition indicates), update the step condition to allow non-PR events.</comment>
<file context>
@@ -452,6 +456,7 @@ jobs:
- name: Track Docker image sizes
uses: ./.github/actions/docker-image-size-tracker
+ if: github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
</file context>
| if: github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository | |
| if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) |
| return Promise.reject(new MeteorError('error-no-body', 'Request has no body')); | ||
| } | ||
|
|
||
| const nodeStream = Readable.fromWeb(request.body as any); |
There was a problem hiding this comment.
P2: Attach an error handler to the Node stream produced by Readable.fromWeb() before piping so stream errors reject the upload instead of crashing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/lib/MultipartUploadHandler.ts, line 199:
<comment>Attach an error handler to the Node stream produced by `Readable.fromWeb()` before piping so stream errors reject the upload instead of crashing.</comment>
<file context>
@@ -0,0 +1,205 @@
+ return Promise.reject(new MeteorError('error-no-body', 'Request has no body'));
+ }
+
+ const nodeStream = Readable.fromWeb(request.body as any);
+ nodeStream.pipe(bb);
+ }
</file context>
| }); | ||
|
|
||
| if (request instanceof IncomingMessage) { | ||
| request.pipe(bb); |
There was a problem hiding this comment.
P2: Handle IncomingMessage stream errors before piping to busboy so aborted uploads reject cleanly instead of emitting an unhandled stream error.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/lib/MultipartUploadHandler.ts, line 193:
<comment>Handle `IncomingMessage` stream errors before piping to busboy so aborted uploads reject cleanly instead of emitting an unhandled stream error.</comment>
<file context>
@@ -0,0 +1,205 @@
+ });
+
+ if (request instanceof IncomingMessage) {
+ request.pipe(bb);
+ } else {
+ if (!request.body) {
</file context>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #38281 +/- ##
==========================================
+ Coverage 70.64% 70.74% +0.09%
==========================================
Files 3145 3142 -3
Lines 108708 108927 +219
Branches 19508 19577 +69
==========================================
+ Hits 76798 77061 +263
+ Misses 29909 29868 -41
+ Partials 2001 1998 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
20 participants
You can see below a preview of the release change log:
8.1.0
Engine versions
22.16.01.43.58.21.59.1-rc.0Minor Changes
(#37954) Changes OAuth login process to update users' names throughout the whole workspace when an existing user logs in with a changed name
(#38032) Enables the password policy by default to ensure security by default and alters SetupWizard to handle errors
(#38077) Changes list of Room Files to only show files that have been successfully attached to a message
Patch Changes
(#38210) Fixes integration saving error because of missing babel dependencies inside the docker container
(#38183) Fixes
/sendEmailAttachmentto support sending multiple file attachments in a single email(#38081) Fixes an issue where cancelling a file upload results in an uncaught exception
(#38169) Introduces in the call widget a quick link that redirects to the participant's direct message
(#37660) Fixes browser slowdowns by preventing a rare cascading of language preference updates when multiple tabs reload
(#38101 by @smirk-dev) Adds error handling for MONGO_OPTIONS environment variable JSON parsing
(#38036 by @dodaa08) Fixes an issue where words are breaking mid-character in user card's bio
(#38151) Changes OEmbed URL processing. Now, the processing is done asynchronously and has a configurable timeout for each request. Additionally, the
API_EmbedIgnoredHostssetting now accepts wildcard domains.(#37951) Fixes incorrect permission checks on workspace registration status, aligning the API and UI hooks with manage-cloud access.
(#38040 by @harshjdhv) Fixes a variable shadowing issue preventing new visitor registration in
livechat/messagesAPI.(#38184) Fixes email notifications to display all files when a message contains multiple attachments
(#38186) Prevents custom status being saved in local storage as
undefinedand breaking the UI when accessing it(#38106) Fixes an issue with the file type blacklist being easily bypassed by changing the file's extension
(#37950) Fixes premium capability popup showing despite active enterprise license.
(#38088) Changes users.getAvatar endpoint to prevent unauthorized access.
(#38068) Fixes an issue that caused a spike in memory usage when apps handled the IPreFileUpload event
(#37919) Makes roomsPerGuest exclude DMs when counting subscriptions, ensuring guest limits apply only to non-DM rooms as per expected behavior.
(#38105) Fixes user deletion not removing thumbnails of images sent by the deleted user
(#38127) Fixes workspace statistics deployment data not updating on server version changes.
(#38119) Ensures SAML respects blank custom Authn Context
(#38071) Improves file upload flow to prevent buffering of contents in memory
Updated dependencies [f4fa393, 00b36c5, e639382, 7b51ba8, 719b85a, 5c3c52b, 1e0b37f, 9a20563, 6654c5b, 020dfbc, c547985, 5fa1509, 05c415b, ccd7694]: