Skip to content

Security Fixes #6354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
engelgabriel merged 4 commits into from
Mar 16, 2017
Merged

Security Fixes #6354

engelgabriel merged 4 commits into from
Mar 16, 2017

Conversation

@kamushadenes
Copy link
Contributor

@kamushadenes kamushadenes commented Mar 13, 2017

@RocketChat/core

Closes issues #1, #2 and #3 from security repo

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kamushadenes
kamushadenes commented Mar 13, 2017
View reviewed changes
packages/rocketchat-file-upload/server/lib/requests.js Outdated
Copy link
Contributor Author

@kamushadenes kamushadenes Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased

@theblazehen
Copy link

theblazehen commented Mar 14, 2017

Doesn't address #3, just perhaps my one example of it. Will comment on the issue in the security repo

@engelgabriel engelgabriel merged commit 0320520 into RocketChat:develop Mar 16, 2017
@engelgabriel engelgabriel added this to the 0.54.0 milestone Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees

@rodrigok rodrigok

Labels

None yet

Projects

None yet

Milestone

0.54.0

Development

Successfully merging this pull request may close these issues.

5 participants

@kamushadenes @CLAassistant @theblazehen @rodrigok @engelgabriel