abstract asset storage #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license for open-web-start is BSD 3-clause. The third clause essentially prohibits non-copyright-holders from using the project 'trademarks'. While it calls out only the name of the project/copyright holders, for good measure I don't want to use any of the assets if I package this in another binary. This change abstracts the GUI assets so the packager is responsible for provisioning them. This isn't the *best* interface, since the set of assets is not encoded in the interface, meaning a new version could break compatibility without the compiler catching it. But, it works well enough. We could always extend the interface to have explicit getters in the future if it proves problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license for open-web-start is BSD 3-clause. The third clause
essentially prohibits non-copyright-holders from using the project
'trademarks'. While it calls out only the name of the project/copyright
holders, for good measure I don't want to use any of the assets if I
package this in another binary.
This change abstracts the GUI assets so the packager is responsible for
provisioning them. This isn't the best interface, since the set of
assets is not encoded in the interface, meaning a new version could
break compatibility without the compiler catching it. But, it works well
enough. We could always extend the interface to have explicit getters in
the future if it proves problematic.
Note: I noticed that some of the assets in the generated file don't actually exist. I'm not sure if this is intentional or not. I also noticed that it was checked in despite being in .gitignore. Either way, I kept the generated file the same, excepting the package name. I didn't regenerate it.