Apostrophe & more poetic numeral tests#268
Open
SpecificProtagonist wants to merge 1 commit intoRockstarLang:mainfrom
Open
Apostrophe & more poetic numeral tests#268SpecificProtagonist wants to merge 1 commit intoRockstarLang:mainfrom
SpecificProtagonist wants to merge 1 commit intoRockstarLang:mainfrom
Conversation
SpecificProtagonist
force-pushed
the
apostrophe-and-literal-test
branch
from
7d89953 to
e1b7225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some test cases where Satriani was non-compliant with the spec.
In particular, the old apostrophesIgnored test didn't check for apostrophes in general, but within poetic numerals, where any non-letter (apart from the first .) are ignored. I instead added other checks where apostrophes have to be ignored even when not in peotic numerals, which in most cases (e.g.
Foo' is ok) caused Satriani to fail to parse the test. At the moment, single quotes are very annoying to implement correctly for very little benefit, so changing the spec instead would probably be a good idea.The poetic literal test now also checks for ignoring non-letters and the possibility of non-ASCII letters (which can hang Satriani if used as the start and fail to parse elsewise).