Skip to content

[refactor] make function for abstract operation on random number #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pehdfms wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[refactor] make function for abstract operation on random number #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aeb6e4
refactor: abstract operations on random numbers
pehdfms Oct 18, 2022
f85beca
refactor: break down to multiple operations
pehdfms Oct 18, 2022
95300a2
refactor: 2 spaces
pehdfms Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions refactor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,18 @@ function returnRandomNumber() {
return Math.random();
}

function sumToRandomNumber(num) {
const numberToSum = returnRandomNumber();
function operateRandomNumber(num, operation) {
// Número aléatorio entre 0 e 100
const randomNumber = Math.round(returnRandomNumber() * 100);
const result = operation(randomNumber, num);

return `Seu número é ${Math.round(numberToSum * 100) + num}!`;
return `Seu número é ${result}!`;
}

function subtractRandomNumber(num) {
const numberToSubtract = returnRandomNumber();

return `Seu número é ${Math.round(numberToSubtract * 100) - num}!`;
}

function multiplyToRandomNumber(num) {
const numberToMultiply = returnRandomNumber();

return `Seu número é ${Math.round(numberToMultiply * 100) * num}!`;
}

function divideRandomNumber(num) {
const numberToDivide = returnRandomNumber();

return `Seu número é ${Math.round(numberToDivide * 100) / num}!`;
}
// Para não estragarmos a interface publica, recriamos os metodos antigos com a nova mudança
// Além de diminuir a repetição de código, agora podemos também criar operações arbitrarias
// utilizando operateRandomNumber.
const sumToRandomNumber = (num) => operateRandomNumber(num, (a, b) => a + b);
const subtractRandomNumber = (num) => operateRandomNumber(num, (a, b) => a - b);
const multiplyToRandomNumber = (num) => operateRandomNumber(num, (a, b) => a * b);
const divideRandomNumber = (num) => operateRandomNumber(num, (a, b) => a / b);