Implement a possibility to create a build without starting server#44
Open
xhujerr wants to merge 2 commits intoRodrigoGonzalez:mainfrom
Open
Implement a possibility to create a build without starting server#44xhujerr wants to merge 2 commits intoRodrigoGonzalez:mainfrom
xhujerr wants to merge 2 commits intoRodrigoGonzalez:mainfrom
Conversation
Reviewer's GuideThis PR introduces a Sequence diagram for build process with and without --no-server flagsequenceDiagram
actor User
participant CLI as check_mkdocs CLI
participant MkDocs as MkDocs
User->>CLI: Run check_mkdocs [--no-server]
CLI->>CLI: Parse arguments
CLI->>MkDocs: Build documentation
MkDocs-->>CLI: Build result
alt --no-server flag is NOT set
CLI->>CLI: Start MkDocs server
CLI->>MkDocs: mkdocs serve
MkDocs-->>CLI: Server runs briefly
CLI->>MkDocs: Terminate server
else --no-server flag is set
CLI->>CLI: Skip starting server
end
CLI-->>User: Return status
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @xhujerr - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `CHANGELOG.md:2` </location>
<code_context>
+## v1.2.0 (2025-07-11)
+- adedd --no-server option
+
## v1.2.0 (2023-08-22)
</code_context>
<issue_to_address>
Typo: 'adedd' should be 'added'.
Please change 'adedd' to 'added'.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
- adedd --no-server option
=======
- added --no-server option
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intro
This is to address the issue #43
Implementation
There is added an option
--no-server. The code starting the server is now wrapped in an if and is skipped when the--no-serveris passed.It is attempted as a minimal change to the code. Some formatting changes were added automatically by the Python Black.
Summary by Sourcery
Add a --no-server option to allow building documentation without starting the MkDocs server.
New Features:
Enhancements:
Documentation: