Fix local db path for Civic Intelligence Refinement Engine#548
Fix local db path for Civic Intelligence Refinement Engine#548RohanExploit wants to merge 1 commit intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for fixmybharat canceled.
|
👷 Deploy Preview for fixmybharat processing.
|
🙏 Thank you for your contribution, @RohanExploit!PR Details:
Quality Checklist:
Review Process:
Note: The maintainers will monitor code quality and ensure the overall project flow isn't broken. |
📝 WalkthroughWalkthroughThree files were modified or added: new JSON data files for daily snapshots and model weights configuration, plus a database path update in the daily refinement job scheduler. These are primarily static data additions with one configuration path change. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="data/modelWeights.json">
<violation number="1" location="data/modelWeights.json:10">
P2: Don't check in the generated `modelWeights.json` state file; the service already seeds defaults and rewrites this file on every run.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "Flooding": 8 | ||
| }, | ||
| "duplicateThreshold": 0.83, | ||
| "lastUpdated": "2026-03-14T19:32:45.319Z", |
There was a problem hiding this comment.
P2: Don't check in the generated modelWeights.json state file; the service already seeds defaults and rewrites this file on every run.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At data/modelWeights.json, line 10:
<comment>Don't check in the generated `modelWeights.json` state file; the service already seeds defaults and rewrites this file on every run.</comment>
<file context>
@@ -0,0 +1,35 @@
+ "Flooding": 8
+ },
+ "duplicateThreshold": 0.83,
+ "lastUpdated": "2026-03-14T19:32:45.319Z",
+ "history": [
+ {
</file context>
There was a problem hiding this comment.
Pull request overview
This PR aims to make the TypeScript Daily Civic Intelligence Refinement Engine run locally out-of-the-box by correcting the SQLite DB path to align with the backend’s default ./data/issues.db location.
Changes:
- Update
scheduler/dailyRefinementJob.tsto use../data/issues.dbas the default DB fallback path. - Add
data/modelWeights.json(adaptive weights state) to the repo. - Add
data/dailySnapshots/2026-03-14.json(daily snapshot output) to the repo.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scheduler/dailyRefinementJob.ts | Points the scheduler’s default SQLite path at the repo-root data/issues.db. |
| data/modelWeights.json | Introduces a checked-in adaptive weights state file used by TS services. |
| data/dailySnapshots/2026-03-14.json | Introduces a checked-in daily snapshot output file generated by the TS engine. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "duplicateThreshold": 0.83, | ||
| "lastUpdated": "2026-03-14T19:32:45.319Z", | ||
| "history": [ | ||
| { | ||
| "date": "2026-03-14", | ||
| "categoryWeights": { | ||
| "Pothole": 5, | ||
| "Garbage": 3, | ||
| "Water Supply": 4, | ||
| "Streetlight": 2, | ||
| "Flooding": 8 | ||
| }, | ||
| "duplicateThreshold": 0.85 | ||
| }, | ||
| { | ||
| "date": "2026-03-14", | ||
| "categoryWeights": { | ||
| "Pothole": 5, | ||
| "Garbage": 3, | ||
| "Water Supply": 4, | ||
| "Streetlight": 2, | ||
| "Flooding": 8 | ||
| }, | ||
| "duplicateThreshold": 0.84 | ||
| } | ||
| ] |
| "categoryWeights": { | ||
| "Pothole": 5, | ||
| "Garbage": 3, | ||
| "Water Supply": 4, | ||
| "Streetlight": 2, | ||
| "Flooding": 8 | ||
| }, |
| "date": "2026-03-14", | ||
| "indexScore": 50, | ||
| "delta": 0, | ||
| "topKeywords": [], | ||
| "emergingConcerns": [] |
| // Load environmental or fallback to test.db or production db | ||
| const dbPath = | ||
| process.env.DB_PATH || path.join(__dirname, "../../backend/app.db"); | ||
| process.env.DB_PATH || path.join(__dirname, "../data/issues.db"); | ||
|
|
The Daily Civic Intelligence Refinement Engine was already fully implemented and verified in the repository across
services/andscheduler/usingnode-cron,sqlite3, andTypeScript. The only necessary fix was correcting thedbPathindailyRefinementJob.tsto properly point to../data/issues.dbto align with the backend database. This allows the local local engine to run out of the box. Test coverage via Jest exists and has been successfully executed.PR created automatically by Jules for task 11492202192856182422 started by @RohanExploit
Summary by cubic
Fixes the local DB path for the Daily Civic Intelligence Refinement Engine so the scheduler uses ../data/issues.db and runs out of the box. Adds default model weights (data/modelWeights.json) and a generated daily snapshot (data/dailySnapshots/2026-03-14.json).
Written for commit e5a3b71. Summary will update on new commits.
Summary by CodeRabbit