Skip to content

fix: prevent greetings workflow 0-job failure runs on push/synchronize events#550

Draft
Copilot wants to merge 2 commits intobolt-priority-engine-opt-v2-17124686792412411432from
copilot/debug-workflow-check-failures
Draft

fix: prevent greetings workflow 0-job failure runs on push/synchronize events#550
Copilot wants to merge 2 commits intobolt-priority-engine-opt-v2-17124686792412411432from
copilot/debug-workflow-check-failures

Conversation

Copy link
Contributor

Copilot AI commented Mar 15, 2026

Description

greetings.yml was producing failure workflow runs with 0 jobs whenever a branch was pushed. GitHub evaluates pull_request_target workflows on push/synchronize events; since the workflow only declared types: [opened], no jobs were scheduled — and GitHub marks 0-job runs as failure.

Fix: Add an explicit if: guard to the greeting job:

jobs:
  greeting:
    if: github.event_name == 'issues' || github.event_name == 'pull_request_target'

When the job condition is false, GitHub skips it (run concludes success) instead of creating an empty run that fails. No change to functional behavior on issues: opened or pull_request_target: opened events.

The other three workflows (pr-issue-bot.yml, assign-pr-author-on-merge.yml, auto-close-mentioned-issues.yml) already have job-level if: guards and were not affected.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Code style update (formatting, renaming)
  • ♻️ Refactoring (no functional changes)
  • ⚡ Performance improvement
  • ✅ Test update

Related Issue

Testing Done

  • Tested locally
  • Added/updated tests
  • All tests passing

Screenshots (if applicable)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Co-Authors

Original prompt

Reference: https://github.com/RohanExploit/VishwaGuru/commit/457de3eae941ced15dddd6630bffd0de65652f62/checks?check_suite_id=60507107873
check failures of evwry workflow and debug them, make every workflow run


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Summary by cubic

Prevents phantom CI failures by adding an event guard to the greetings workflow so it only runs on issues and pull_request_target. Other workflows already had proper guards, so this eliminates 0‑job failures on push/synchronize and restores green checks.

Written for commit 96c60cd. Summary will update on new commits.

@github-actions
Copy link

🙏 Thank you for your contribution, @Copilot!

PR Details:

Quality Checklist:
Please ensure your PR meets the following criteria:

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Code is commented where necessary
  • Documentation updated (if applicable)
  • No new warnings generated
  • Tests added/updated (if applicable)
  • All tests passing locally
  • No breaking changes to existing functionality

Review Process:

  1. Automated checks will run on your code
  2. A maintainer will review your changes
  3. Address any requested changes promptly
  4. Once approved, your PR will be merged! 🎉

Note: The maintainers will monitor code quality and ensure the overall project flow isn't broken.

Co-authored-by: RohanExploit <178623867+RohanExploit@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix workflow check failures and ensure all run fix: prevent greetings workflow 0-job failure runs on push/synchronize events Mar 15, 2026
Copilot AI requested a review from RohanExploit March 15, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants