Skip to content

Handle greetings workflow gracefully on non-issue events#551

Draft
Copilot wants to merge 3 commits intobolt-priority-engine-opt-v2-17124686792412411432from
copilot/improve-workflow-stability
Draft

Handle greetings workflow gracefully on non-issue events#551
Copilot wants to merge 3 commits intobolt-priority-engine-opt-v2-17124686792412411432from
copilot/improve-workflow-stability

Conversation

Copy link
Contributor

Copilot AI commented Mar 15, 2026

Description

Greetings workflow was failing on the referenced commit because it ran on push and lacked issue/PR context. This change hardens the workflow to skip unsupported events and require valid issue/PR data before posting.

  • Workflow hardening: Skip unsupported events up front and bail out when issue/PR context is absent to prevent runtime failures.
  • Safety checks: Require issue_number derivation from the validated payload, avoiding null accesses during push-triggered runs.

Example change:

const supportedEvents = ['issues', 'pull_request_target'];
if (!supportedEvents.includes(context.eventName)) {
  core.info(`Skipping unsupported event: ${context.eventName}`);
  return;
}
const issue_number = isPullRequest ? context.payload.pull_request.number : context.payload.issue.number;

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Code style update (formatting, renaming)
  • ♻️ Refactoring (no functional changes)
  • ⚡ Performance improvement
  • ✅ Test update

Related Issue

Testing Done

  • Tested locally
  • Added/updated tests
  • All tests passing

Screenshots (if applicable)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Co-Authors

Original prompt

Reference: https://github.com/RohanExploit/VishwaGuru/commit/16ac0bbb4c5b9bdfcda7722986808d218f80f43b/checks?check_suite_id=60502599288

ir keeps on fialing no this and other workflow should fail again , i want this app works s.otthly conduct heavy audit and start working on issues


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.


Summary by cubic

Fixes the failing greetings GitHub Actions workflow so it skips unsupported events and missing PR/issue context instead of erroring, reducing CI flakiness.

  • Bug Fixes
    • CI: Add an allowlist for issues and pull_request_target, guard when no issue_number exists, and log skips with core.info in .github/workflows/greetings.yml.

Written for commit c8e2ce4. Summary will update on new commits.

@github-actions
Copy link

🙏 Thank you for your contribution, @Copilot!

PR Details:

Quality Checklist:
Please ensure your PR meets the following criteria:

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Code is commented where necessary
  • Documentation updated (if applicable)
  • No new warnings generated
  • Tests added/updated (if applicable)
  • All tests passing locally
  • No breaking changes to existing functionality

Review Process:

  1. Automated checks will run on your code
  2. A maintainer will review your changes
  3. Address any requested changes promptly
  4. Once approved, your PR will be merged! 🎉

Note: The maintainers will monitor code quality and ensure the overall project flow isn't broken.

@RohanExploit
Copy link
Owner

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Reference: https://github.com/RohanExploit/VishwaGuru/commit/16ac0bbb4c5b9bdfcda7722986808d218f80f43b/checks?check_suite_id=60502599288

ir keeps on fialing no this and other workflow should fail again , i want this app works s.otthly conduct heavy audit and start working on issues


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.


Summary by cubic

Stabilizes CI by fixing failing GitHub Actions workflows and adds small runtime guards to reduce crashes. Builds should be green and less flaky, and the app starts more reliably.

  • Bug Fixes
    • CI: Pin actions/checkout@v4 and actions/setup-node@v4, switch to Node LTS, and remove deprecated set-output.
    • CI: Fix GITHUB_TOKEN permissions and working directories; enable setup-node cache for pnpm; retry pnpm install on network failures.
    • App: Validate required env vars on startup and add a /health endpoint to surface misconfig before runtime errors.

Written for commit 8293dd1. Summary will update on new commits.

@copilot also solve the suggeations givenby cubic

Copilot AI and others added 2 commits March 15, 2026 12:00
Co-authored-by: RohanExploit <178623867+RohanExploit@users.noreply.github.com>
Co-authored-by: RohanExploit <178623867+RohanExploit@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing workflows and improve app stability Handle greetings workflow gracefully on non-issue events Mar 15, 2026
Copilot AI requested a review from RohanExploit March 15, 2026 12:02
Copy link
Contributor Author

Copilot AI commented Mar 15, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

...

I dug through the repo and the current workflows only use github-script (no checkout/setup-node/pnpm or set-output), and the backend already exposes /health plus validates env like FRONTEND_URL for production in backend/main.py. Can you point me to a specific workflow or env check you’d like tightened so I can adjust it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants