Skip to content

Ensure the pdf has been created before yielding to the block #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikehale merged 1 commit into from
Jan 26, 2026
Merged

Ensure the pdf has been created before yielding to the block #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/chromium/pdf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,15 @@ def generate_pdf!(unescaped_filename, print_url, arguments: DEFAULT_CHROME_ARGUM

def chrome_print(chrome_path, print_url, filename, filepath, arguments, &block)
Kernel.system("LD_PRELOAD='' #{chrome_path} --print-to-pdf='#{filepath}' #{arguments.join(' ')} #{print_url}")
sleep 0.1 until file_created?(filepath)

File.open(filepath) do |file|
block&.call(file, filename)
end
end

def file_created?(filepath)
File.exist?(filepath) && File.size(filepath).positive?
end
end
end
4 changes: 4 additions & 0 deletions test/jobs/test_generate_pdf_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,8 @@ class TestGeneratePdfJob
def perform(filename, url)
generate_pdf!(filename, url)
end

def file_created?(...)
true
end
end