Skip to content

Refactor getNetworkForIp for Android<=10, use RouteInfo instead of LinkAddress #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor getNetworkForIp for Android<=10, use RouteInfo instead of LinkAddress #442

wants to merge 1 commit into from

Conversation

@davidalo
Copy link

@davidalo davidalo commented Nov 17, 2025

  • In Android 10, with previous versions of Android SDK this fallback was working but something changed. The previous logic was incorrect and was matching the host ip (current device) with the targetHostIp (the device we want to connect to).
  • Code is now more robust and uses DHCP (A11+) or Route info (A10 or older, and A11+ if DHCP fails)

@davidalo
Refactor getNetworkForIp for Android<=10, use RouteInfo instead of Li…
c161621 
…nkAddress

* In Android 10, with previous versions of Android SDK this fallback was working but something changed. The previous logic was incorrect and was matching the host ip (current device) with the targetHostIp (the device we want to connect to).
* Code is now more robust and uses DHCP (A11+) or Route info (A10 or older, and A11+ if DHCP fails)
@davidalo davidalo marked this pull request as draft November 17, 2025 11:45
@davidalo davidalo marked this pull request as ready for review November 17, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidalo