Conversation
han4wluc
reviewed
Dec 26, 2025
| @@ -0,0 +1,452 @@ | |||
| --- | |||
han4wluc
reviewed
Dec 26, 2025
| saveSlots: | ||
| "1": | ||
| slotKey: "1" | ||
| date: __ignore__ |
Contributor
There was a problem hiding this comment.
this should be actual value?
Contributor
There was a problem hiding this comment.
there is only undefined but not ignore
han4wluc
reviewed
Dec 26, 2025
|
|
||
| state.global.saveSlots[slotKey] = saveData; | ||
|
|
||
| localStorage.setItem("saveSlots", JSON.stringify(state.global.saveSlots)); |
Contributor
There was a problem hiding this comment.
this also need to be moved to effect
|
|
||
| const currentState = { | ||
| projectData: state.projectData, | ||
| contexts: [...state.contexts] |
Contributor
There was a problem hiding this comment.
need to store these
viewedRegistry
contexts
Contributor
Author
demo-screenshot.mp4 |
han4wluc
approved these changes
Dec 26, 2025
| contexts: [...state.contexts] | ||
| }; | ||
|
|
||
| // const url = await captureElement("story"); |
Contributor
There was a problem hiding this comment.
it has to be a 2 step thing:
// saveSaveSlot step 1
state.global.pendingEffects.push(
{ name: 'saveScreeshot', payload: { slotKey } },
);
// in effectsHandler
const saveScreenshot = async () => {
const base64Img = await routeGraphics.captureElement('story')
engine.handleAction('saveSaveSlot', { slotKey, image: base64Img })
}
| saveSlots: | ||
| "2": | ||
| slotKey: "2" | ||
| date: __ignore__ |
Contributor
There was a problem hiding this comment.
remove these __ignore__ otherwise seems good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will probably change globalSaveStory and globalLoadStory later, and the image is still a WIP
Demo.save.and.load.mp4