Added default hotkey for settings window.#218
Open
Muuulya wants to merge 1 commit intoRoversX:mainfrom
Open
Conversation
Owner
|
Thanks for the PR. This only matters for regular apps with a system menu bar. Our app runs with LSUIElement=YES (no menu bar), so ⌘, doesn’t fire. In practice this change has little effect. Is that correct? |
Contributor
Author
|
Yes, it has a minimal effect. But I think it’s provides the best user experience, because this hotkey combination is familiar and common. I verified this change in practice: when the Launchpad window is active ⌘, does fire. The command works as intended and opens the settings sheet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, the default hotkey for settings (⌘+,) opens an empty window. I fixed this, and now the correct settings window opens.