Clarifying id/label requirement/capability for pedigree() and fixing getASubset()#5
Open
gregorgorjanc wants to merge 7 commits intoRpedigree:masterfrom
Open
Clarifying id/label requirement/capability for pedigree() and fixing getASubset()#5gregorgorjanc wants to merge 7 commits intoRpedigree:masterfrom
gregorgorjanc wants to merge 7 commits intoRpedigree:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I got bitten by
getASubset()assuming that ids/labels are1:n, while they can be pretty much anything.In this PR I did two things:
pedigree()(since we use factors we are extremely flexible here, maybe even too much!? - I have now shown examples what is and is not allowed to make this clear)getASubset()to allow for ids/labels that are not just1:nWhile I think this is all good and a step in the right direction, I am wondering/pondering/worrying if other functions also work with this very flexible id/labelling scheme. I can go away and check and add test/show cases, but though best opening this PR earlier to get some feedback and discussion if this is really what we want.