Removed unneeded comment #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,6 @@ class Softsign implements ActivationFunction, IBufferDerivative | |||
| */ | |||
| public function activate(NDArray $input) : NDArray | |||
| { | |||
| // Calculate |x| | |||
There was a problem hiding this comment.
Nice, but what about the rest of the comments? I might have not been as clear as I could have in my review, sorry for that, but I meant it to apply to all of these types of comments in this class and any similar class not just the one on this line.
andrewdalpino
approved these changes
Aug 12, 2025
apphp
merged commit c52161a
into
RubixML:convert-activation-functions-to-numpower
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.