Improve currency symbol detection #185
Conversation
|
we are having an issue with CI being automatically run. if someone figures it out, or we get to it ourselves, we can merge this (and all other PRs) right away. |
|
what's the issue with the CI? maybe I can help |
|
the workflows all stopped being detected. no tests are running across any repo |
RubenIgnacio
force-pushed
the
improve-currency-symbol-detection
branch
from
5cddd04 to
014c5c9
Compare
|
i just did a test and the workflow ran okay. i understand that for PRs coming from forks for the first time, it requires reviewer approval before running workflow tests. could that be the issue you're encountering, or do you have another workflow problem? |
|
Nope. It used to work. Now when I authorize it just runs code climate and not the full CI pipeline. Happy to grant repo access to the org if you would like to dive in.
Cheers.
🤘SE
…On Mon, Apr 28, 2025 at 2:09 PM, RubenIgnacio < ***@***.*** > wrote:
*RubenIgnacio* left a comment (RubyMoney/ monetize#185) (
#185 (comment) )
i just did a test and the workflow ran okay. i understand that for PRs
coming from forks for the first time, it requires reviewer approval before
running workflow tests. could that be the issue you're encountering, or do
you have another workflow problem?
—
Reply to this email directly, view it on GitHub (
#185 (comment) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAGYHYI3BRUFUL2GIE2ICL23ZVEPAVCNFSM6AAAAABV3IIG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZWGA3TINZSGE
).
You are receiving this because you commented. Message ID: <RubyMoney/monetize/pull/185/c2836074721
@ github. com>
|
|
sure, I can take a look |
|
@RubenIgnacio you are now an owner, though I think I may have fixed them... |
|
thanks for the access. did you find the problem? we could try creating a new branch, setting up the workflow there, and sending a PR with any change to test, so we don't affect main. so far, I think it could be a GH problem, because as you mentioned, the tests are failing in all repos, and I haven't found anything strange in the config. |
|
maybe it's a image version. they have all been static for years. feel free to try anything you can think of
Cheers.
🤘SE
…On Tue, Apr 29, 2025 at 16:30, RubenIgnacio < ***@***.*** > wrote:
*RubenIgnacio* left a comment (RubyMoney/monetize#185) (
#185 (comment) )
thanks for the access. did you find the problem? we could try creating a
new branch, setting up the workflow there, and sending a PR with any
change to test, so we don't affect main. so far, I think it could be a GH
problem, because as you mentioned, the tests are failing in all repos, and
I haven't found anything strange in the config.
—
Reply to this email directly, view it on GitHub (
#185 (comment) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAGYH4XONVYRDJ2MF3KWJT2374SDAVCNFSM6AAAAABV3IIG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBQGM4DANRTGA
).
You are receiving this because you commented. Message ID: <RubyMoney/monetize/pull/185/c2840380630
@ github. com>
|
|
@semmons99 Hi, I tested in another branch with a friend and the CI works. I think now we just need to be careful if it happens again. |
The version v1.13.0 of monetize currently detects limited currency symbols. For example:
Expected behavior:
Current behavior:
Proposed Solution
The
Money::Currency.tablecan be used to retrieve the list of currency symbols. In cases where symbols are repeated, thedisambiguate_symbolcan be used as the symbol. However, this solution has some limitations:To address these limitations, such symbols will be ignored during parsing. Additionally, any problematic symbols can be added to a list of ignored symbols to prevent issues. This can be a starting point but can be refined further to handle more cases and support additional symbols in the future.