fix: correct zustand useShallow import path in AppModals#484
Merged
pedramamini merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: correct zustand useShallow import path in AppModals#484pedramamini merged 1 commit intomainfrom
pedramamini merged 1 commit intomainfrom
Conversation
The import was using `zustand/shallow` which doesn't export `useShallow` in zustand 4.5.x, causing it to resolve as `unknown` and cascading 30+ type errors. The correct path is `zustand/react/shallow`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe import path for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR corrects the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 2f7b55d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useShallowimport path inAppModals.tsxfromzustand/shallowtozustand/react/shallowuseShallowto resolve asunknownin zustand 4.5.x, cascading into 30+ type errors on destructured modal propertiesTest plan
npm run lintpassesnpm run lint:eslintpassesnpm run testpasses (508 files, 21,547 tests, 0 failures)Summary by CodeRabbit
Note: This release contains internal maintenance updates with no user-visible changes or new features.