Conversation
Closed
4 tasks
Test Coverage Report
|
west-eastH
approved these changes
Jul 14, 2025
Comment on lines
+22
to
+28
| @Operation(summary = "유저 정보 저장", description = "온보딩에서 유저 정보를 저장하는 API 입니다.") | ||
| @PostMapping("/onboarding") | ||
| public CommonResponse<Void> saveMemberInfo(@Login Member member, MemberInfoRequest request) { | ||
|
|
||
| memberService.saveMember(member, request); | ||
| return new CommonResponse<>("유저의 기본 정보 저장 완료"); | ||
| } |
Contributor
There was a problem hiding this comment.
오 이거 이전 커밋에서 저도 만들었는데 서지님 코드가 더 좋아보이네여.. 피그마 보니까 프로필 이미지도 받아야 할 것 같아서 멀티파트파일로 받았는데 여기에 프로필 이미지 받는것만 추가해주시고 제 코드는 지워주시면 감사하겠습니다!(run.backend.domain.auth.controller -> signup)
Contributor
Author
There was a problem hiding this comment.
헉!! 아 저 과정을 회원가입의 일부로 생각하셨군요..!
일단 저는 회원가입 + 로그인 끝나고 그냥 기본 정보 입력하는 느낌으로 생각했는데..회원가입 과정에 포함시키는게 더 좋을까요?
Comment on lines
+14
to
+19
| @Query(""" | ||
| SELECT jc.crew | ||
| FROM JoinCrew jc | ||
| WHERE jc.member.id = :memberId | ||
| AND jc.joinStatus = :status | ||
| """) |
Contributor
Author
There was a problem hiding this comment.
쿼리dsl은 아직.. ㅠㅜ 설정 추가하면 쿼리 dsl로 바꿀라구요!
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class LoginArgumentResolver implements HandlerMethodArgumentResolver { |
Contributor
There was a problem hiding this comment.
참고해서 크루도 이런식으로 만들어둘까요??
Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 연관된 이슈
📝 작업 내용 (주요 변경 사항)
💬 리뷰 요구사항