Skip to content

fix: metrics for remaining segment types#88

Open
gyr0tron wants to merge 3 commits intodevelopfrom
fix/add_metrics_noise_flat
Open

fix: metrics for remaining segment types#88
gyr0tron wants to merge 3 commits intodevelopfrom
fix/add_metrics_noise_flat

Conversation

@gyr0tron
Copy link
Copy Markdown
Collaborator

@gyr0tron gyr0tron commented Apr 10, 2026

Fixes #61:

  • Calculate change/pct_change for all segment types using absolute difference (because we don't have direction, pct_change uses mean value percentage)
  • Remove direction check for total_change calculation
  • Include all segments in change_rank ranking by magnitude

@gyr0tron gyr0tron requested a review from RussellSB April 10, 2026 22:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026 •
edited
Loading

📚 Docs preview deployed!

Your docs preview is available at: https://russellsb.github.io/pytrendy/pr-88/

This preview will be removed when the PR is closed.

github-actions bot added a commit that referenced this pull request Apr 10, 2026
@github-actions
ci(docs): deploy pr preview for #88 at 0658c17 0658c17
2d3087f
github-actions bot added a commit that referenced this pull request Apr 10, 2026
@github-actions
ci(docs): deploy pr preview for #88 at 6125b16 6125b16
c01e9b3
RussellSB
RussellSB requested changes Apr 11, 2026
View reviewed changes
Comment thread pytrendy/io/results_pytrendy.py Outdated
Comment thread pytrendy/post_processing/segments_refine/trend_classify.py
RussellSB
RussellSB requested changes Apr 11, 2026
View reviewed changes
Comment thread pytrendy/post_processing/segments_analyse.py Outdated
@gyr0tron
fix: add trend class for non-up/down segments
fe88cd8 
fix: update artifact cleanup to set trend class instead of deleting for non-up/down segments

fix: update set_best to only consider up/down segments
github-actions bot added a commit that referenced this pull request Apr 11, 2026
@github-actions
ci(docs): deploy pr preview for #88 at 9306f67 9306f67
392caef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RussellSB RussellSB RussellSB requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gyr0tron @RussellSB