gccrs: make invalid inner attributes show error #4237
+37
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
approved these changes
Oct 31, 2025
gcc/rust/util/rust-attributes.cc
Outdated
| {Attrs::PROC_MACRO_ATTRIBUTE, EXPANSION}, | ||
|
|
||
| {Attrs::DERIVE, EXPANSION}, | ||
| = {{Attrs::INLINE, CODE_GENERATION, false}, |
There was a problem hiding this comment.
I think it would be better to add a second map here rather than add a boolean attribute to every BuiltinAttrDefinition
lucasly-ba
force-pushed
the
4219
branch
3 times, most recently
from
2ff2487 to
8098c3b
Compare
gcc/rust/ChangeLog: * ast/rust-ast.cc (Attribute::is_derive): Change is_derive method with its valid path. * util/rust-attribute-values.h: Delete redudant derive attribute. * util/rust-attributes.cc (AttributeChecker::check_inner_attribute): Helper method for check_inner_attributes (AttributeChecker::check_inner_attributes): Implement method for errors check. * util/rust-attributes.h: Add methods above in header. gcc/testsuite/ChangeLog: * rust/compile/issue-4212.rs: * rust/compile/issue-4219.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4219
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: