Increase resilience towards partial cache clears #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
cache-resiliance
branch
from
e7930e6 to
b20219b
Compare
tombh
approved these changes
Oct 8, 2025
|
I was following your #116, I've seen similar weirdness before and just deleted everything to move on. It's great you spent some proper time to look into it. |
This was referenced Oct 8, 2025
|
There's still #72 which is the main kind of error I get from cargo-gpu in my project. Though of the two racing build scripts one usually fails early and you can just rerun it and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #116 we're hit problems where the dylib still exists but the cargo project was deleted. Currently, the install process is skipped if just the dylib file exists. After the install we call
cargo metadatato resolve the toolchain version, which will error if the project was deleted. With this PR, we also detect the project being deleted and do a rebuild, not just when the dylib is missing.Long-term it would probably be better to just store the toolchain version in a metadata json or text file, and not reresolve it each time. With #117 currently refactoring much of cargo-gpu, I think we'll wait for that to complete before implementing it.
closes #116