Make black_box a no-op
#363
Open
+99
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegNeato
commented
Aug 14, 2025
LegNeato
force-pushed
the
blackbox
branch
3 times, most recently
from
d689ea2 to
729aacb
Compare
LegNeato
commented
Aug 14, 2025
Open
Firestar99
requested changes
Aug 18, 2025
| // Preserve both elements by spilling + reloading | ||
| OperandValue::Pair(..) => { | ||
| let tmp = self.alloca(layout.size, layout.align.abi); | ||
| self.store(args[0].immediate(), tmp, layout.align.abi); |
There was a problem hiding this comment.
The implementation of args[0].immediate() is guaranteed to panic, see my latest additions to the test ICE-ing:
pub fn immediate(self) -> V {
match self.val {
OperandValue::Immediate(s) => s,
_ => bug!("not immediate: {:?}", self),
}
}Our ABI takes apart ScalarPairs into an Adt(a, b), but only if the ScalarPair consists out of two non-ZST fields. I have no idea how to correctly load / store ScalarPairs, especially given that condition. Maybe @eddyb can help us here?
There was a problem hiding this comment.
Yeah, I've been feeling around in the dark, no clue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #312