Support scalar pair ABI #381
Conversation
(T, U) pairs in entrypoints and regular functions are now supported.
|
|
||
| let elem0_ty = self.scalar_pair_element_backend_type(layout, 0, false); | ||
| let elem1_ty = self.scalar_pair_element_backend_type(layout, 1, false); | ||
|
|
There was a problem hiding this comment.
@eddyb I am not sure this section is right, can you review?
|
I'll need this PR for #380, since removing our custom |
|
That is fortuitous 🤯 |
| let elem1_ty = self.scalar_pair_element_backend_type(layout, 1, false); | ||
|
|
||
| let base_ptr = value_ptr.unwrap(); | ||
| let ptr1 = bx.inbounds_ptradd(base_ptr, self.const_usize(b_offset.bytes())); |
There was a problem hiding this comment.
Why use inbounds_ptradd here, when it just forwards to inbounds_gep?
fn inbounds_ptradd(&mut self, ptr: Self::Value, offset: Self::Value) -> Self::Value {
self.inbounds_gep(self.cx().type_i8(), ptr, &[offset])
}I'm also not so sure you want the resulting type to implicitly be an i8?
There was a problem hiding this comment.
Yeah, this is what I am not sure about, doing pointer arithmetic is bad and I was going to switch it to gep but wanted eddyb to chime in.
Tuple layout is not guaranteed in Rust though. So at least for entrypoints I'd prefer for it to not be supported to avoid UB, forcing user to create an explicit In fact, any type that is not FFI-safe should generate at least compiler warning if not error, just like when you use |
|
Yeah, I know the repr is not guaranteed in Rust but as you can see in the example we are pushing each piece and then aggregating as a pair on the device side. I guess that is UB though? |
|
That is certainly not how I'd write in an actual host-side code, I'd simply cast If manually pushing bytes in correct order and adding an extra guarantee about tuple order on shader entrypoint then it might not be UB, but it feels unnatural in Rust. |
|
Agreed, probably best to be safe and restrict them from entrypoints. |
|
This is a much more fundamental issue. You can pass structs through buffers that are |
| let r_mix = 8u32 ^ 16u32 ^ 0.5f32.to_bits() ^ (-2.0f32).to_bits(); | ||
| out[12] = p_mix; | ||
| out[13] = q_mix; | ||
| out[14] = r_mix; |
There was a problem hiding this comment.
It looks like this function is computing something very specific but I don't know what it is. A brief comment would be useful.
@nnethercote in https://github.com/Rust-GPU/rust-gpu/pull/380/files/8bdec822a9382c34c96031617a3ae37189621583#r2373605856
(T, U) pairs in entrypoints and regular functions are now supported.