versionize rust_gpu tool to ensure codegen and spirv-std versions match
#401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Firestar99
force-pushed
the
tool_rename
branch
from
a7ed0e4 to
662f4be
Compare
Firestar99
force-pushed
the
tool_rename
branch
from
662f4be to
5b7acff
Compare
Firestar99
changed the title
rust_gpu to rustc_codegen_spirvrust_gpu tool to ensure codegen and spirv-std versions match
Firestar99
commented
Sep 22, 2025
| // NOTE(shesp) Directly using `#[rust_gpu::spirv(...)]` because macro attributes are invalid in most contexts | ||
| // NOTE(shesp) Directly using `#[rust_gpu::spirv_v0_9(...)]` because macro attributes are invalid in most contexts | ||
|
|
||
| #[rust_gpu::spirv( |
There was a problem hiding this comment.
This test is a problem. We can't replace every use with our spirv() proc macro, since some of these are in locations proc macros are illegal to place. Ideas?
Firestar99
force-pushed
the
tool_rename
branch
from
5b7acff to
d37bf4e
Compare
|
@eddyb this is ready for review, best commit by commit since the first one just moved a bunch of code. Open Questions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @eddyb, we would like to versionize our
spirv()macro so you can't accidentally combine two incompatible versions.Also enables the addition of "stable spirv macros" that we can offer backward compat for. This will be used in #380 to allow
glamto define it'sVecNas rust-gpu vectors, for which it must refer to our "rustc tool"rust_gpudirectly instead of going via ourspirv()proc macro, which expands to our tool name.