Skip to content

add [pin_]init_scope to execute code before creating an initializer #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add [pin_]init_scope to execute code before creating an initializer #86

wants to merge 1 commit into from

Conversation

@BennoLossin
Copy link
Member

@BennoLossin BennoLossin commented Oct 8, 2025

No description provided.

@BennoLossin BennoLossin force-pushed the dev/init-scope branch 5 times, most recently from 91f324f to 7f2ed79 Compare October 9, 2025 12:38
nbdd0121
nbdd0121 reviewed Oct 9, 2025
View reviewed changes
@BennoLossin
Copy link
Member Author

BennoLossin commented Oct 9, 2025

@dakr @Darksonn if you could do the review here already that would help me a bit with synchronizing to the kernel.

nbdd0121
nbdd0121 previously approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to add my Reviewed-by when sending to the list

dakr
dakr reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@dakr dakr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the comments addressed:

Reviewed-by: Danilo Krummrich <dakr@kernel.org>

dakr
dakr reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@dakr dakr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the comments addressed:

Reviewed-by: Danilo Krummrich <dakr@kernel.org>

dakr
dakr approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@dakr dakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing braces in my RB tag in the commit message, otherwise looks good!

@BennoLossin
add [pin_]init_scope to execute code before creating an initializer
9fb0e4e 
In more complex cases, initializers need to run arbitrary code before
assigning initializers to fields. While this is possible using the
underscore codeblock feature (`_: {}`), values returned by such
functions cannot be used from later field initializers.

The two new functinos `[pin_]init_scope` allow users to first run some
fallible code and then return an initializer which the function turns
into a single initializer. This permits using the same value multiple
times by different fields.

Reviewed-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Benno Lossin <lossin@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbdd0121 nbdd0121 nbdd0121 left review comments

+1 more reviewer

@dakr dakr dakr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BennoLossin @dakr @nbdd0121