fix: silence some unneded warnings in generated code #90
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ddystopia
force-pushed
the
fix_dead_code
branch
from
bf3eeb6 to
1f85d0d
Compare
|
I'm running tests and they pass, so I can't use this:
Can you please suggest how to run tests correctly from my machine? |
|
The test that fails verifies that the generated output hasn't changed. But since you changed it, you should also adjust the test (by using Edit: Ah I forgot to mention that you need to specify |
Ddystopia
force-pushed
the
fix_dead_code
branch
from
1f85d0d to
4595c6a
Compare
|
Do you need me to change the commit message or something like that? |
|
Yes please :) sorry, I'm pretty busy at the moment. |
1. Macro generates a projection structure and if user will not use it, unused warnings for each field are emitted. 2. If a field of a struct has underscore prefix (e.g. `_marker`), a method `_project__marker` will be generated. This is because `_` is unconditionally placed between `project` and a field name. It generates a `non_snake_case` warning due to two underscores. Changing the name itself would be a breaking change and require more powerful macros. Signed-off-by: Oleksandr Babak <alexanderbabak@proton.me>
Ddystopia
force-pushed
the
fix_dead_code
branch
from
4595c6a to
a2ba1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project()method, compiler warns about fields of the projection struct being never read._marker: PhantomData<T>, rust analyzer (not rustc) gives menon_snake_casewarning. This is because of this internal method:$fvis unsafe fn [<_project $field>]<'__slot>. It uses_as a separator but$field` may have it too.