Negative test case for constructed, definite-length octet string #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is incomplete, but here’s an attempt at ensuring that constructed, definite-length method encoded octet strings are detected and rejected. Seeking feedback; I made a few attempts but finally realized what you, @dishmaker, meant by your comment As the I thought it might be fair game to draft a change to the |
dwhjames
force-pushed
the
constructed_definite_octet_string
branch
from
94e1198 to
78a3118
Compare
|
Propagating the original |
tarcieri
reviewed
Jul 9, 2025
tarcieri
reviewed
Jul 9, 2025
dwhjames
force-pushed
the
constructed_definite_octet_string
branch
from
78a3118 to
544e397
Compare
dwhjames
force-pushed
the
constructed_definite_octet_string
branch
from
544e397 to
0c5789e
Compare
tarcieri
reviewed
Jul 17, 2025
tarcieri
reviewed
Jul 17, 2025
dwhjames
force-pushed
the
constructed_definite_octet_string
branch
2 times, most recently
from
fa5700c to
0d37f57
Compare
Ensure octet strings with constructed, definite-length method return an error, rather than an incorrect decoding.
dwhjames
force-pushed
the
constructed_definite_octet_string
branch
from
0d37f57 to
86da1ac
Compare
tarcieri
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure octet strings with constructed, definite-length method return an error, rather than an incorrect decoding.