digest: move EagerHash from hmac
#2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally added in RustCrypto/MACs#151 The situation is `ecdsa` has a trait for the "default" hash function to use for a particular curve, which we want to work with RFC6979 and ergo HMAC, so we would like to use an `EagerHash` bound. But `rfc6979` is an optional dependency, so we can't depend on its transitive accessibility to `rfc6979::hmac`. This PR added `hmac` as a dependency gated on the `digest` feature of `ecdsa`: RustCrypto/signatures#1076 But as I was looking at `EagerHash` I noticed there's nothing HMAC-specific about it at all and it can easily be moved to `digest`, so we're able to use it in bounds without any other dependencies besides `digest`, which would be nice.
|
LGTM! Can do follow-ups tomorrow if they aren't already done by then. |
newpavlov
approved these changes
Sep 16, 2025
This was referenced Sep 16, 2025
|
Let me know if you want me to update any other repo. |
tarcieri
pushed a commit
to RustCrypto/MACs
that referenced
this pull request
Sep 16, 2025
Follow-up to RustCrypto/traits#2014
|
@daxpedda let me know if there are any remaining PRs I haven't reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added in RustCrypto/MACs#151
The situation is
ecdsahas a trait for the "default" hash function to use for a particular curve, which we want to work with RFC6979 and ergo HMAC, so we would like to use anEagerHashbound.But
rfc6979is an optional dependency, so we can't depend on its transitive accessibility torfc6979::hmac. This PR addedhmacas a dependency gated on thedigestfeature ofecdsa:RustCrypto/signatures#1076
But as I was looking at
EagerHashI noticed there's nothing HMAC-specific about it at all and it can easily be moved todigest, so we're able to use it in bounds without any other dependencies besidesdigest, which would be nice.cc @daxpedda