Open
Conversation
Owner
|
Yes, this fix. But it breaks concept of the Countable interface. Or you can delete this interface, and check count methods on other classes. |
Contributor
Author
|
It's not that my patch breaks anything. My patch actually makes the issue described in this bug-report work for I agree that dropping the Countable interface is probably the best idea. Unfortunately, that will break backwards compatibility. Users should be informed about this in the upcoming release. Let me know if you indeed want this approach. I will update my patch accordingly (or you may do so, if you want) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPv6 blocksize can exceed the maximum number for integer (2^32 or 2^64).
This commit fixes
$network->count()[1] (by returning the number of hosts as a string if it exceeds the max integer size). It can't fixcount($network)[2], since PHP'scount()must return an integer.[1] Or
$range->count()[2] Or
count($range)