-
Notifications
You must be signed in to change notification settings - Fork 2
Add configuration for DESPIAD project #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is because resources sharing the same StudyInstanceUID in Orthanc Raw will be combined into a single resource in Orthanc Anon. Previously, we would try to export each resource after anonymisation, but this meant other resources sharing the same StudyInstanceUID were not exported.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 87.51% 87.61% +0.09%
==========================================
Files 76 76
Lines 3437 3505 +68
==========================================
+ Hits 3008 3071 +63
- Misses 429 434 +5 ☔ View full report in Codecov by Sentry. |
04532e7 to
5a47136
Compare
784da58 to
28f92a6
Compare
In orthanc anon plugin, skip series that have few than min_instances_per_series instances
p-j-smith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know the allowed_manufactures we should add for each project?
in case the manufacturer doesn't exist
…ries_number_excluded
stefpiatek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but I think we need to be careful about despiad series to filter out. At least checking an example from each manufacturer for each modality to ensure that we're not exporting burned in PID
p-j-smith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's nearly ready to merge, just a couple of questions about what defaults we want
|
Thanks for the reviews @stefpiatek ! Tests are passing and defaults have been approved, so I think we're good to merge |
Description
Closes #571
Closes #530
ensure all resources sharing aThis has already been fixed in Improve anon logging and anonymise all matching studies at once #582StudyInstanceUIDin Orthanc Raw are exported (they may exist as separate resources in Orthanc Raw if they have differentStudyIDs, but are combined into a single resource in Orthanc Anon as theStudyIDtag is deleted)Type of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.squash and merge