Skip to content

Conversation

@stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented May 29, 2025

We can't have it called pixl because for CI postgres doesn't like it when the database is the same name as the schema. So we had it as pipeline but that doesn't make sense on a shared database like the UDS.

Breaking change but no one else is using it so I think we can squeak this one through

@stefpiatek stefpiatek requested a review from milanmlft May 29, 2025 14:11
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (aa702e3) to head (0932d26).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          76       76           
  Lines        3505     3505           
=======================================
  Hits         3071     3071           
  Misses        434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@stefpiatek stefpiatek merged commit 073c6dc into main Jun 9, 2025
11 checks passed
@stefpiatek stefpiatek deleted the stefpiatek/change-pixl-schema branch June 9, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants