-
Notifications
You must be signed in to change notification settings - Fork 2
Allow PIXL CLI to be installed in non-editable mode #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add 'PIXL_ROOT', 'HOST_EXPORT_ROOT_DIR', and 'HOST_EXPORT_ROOT_DIR_MOUNT' environment variables
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 87.61% 87.59% -0.03%
==========================================
Files 76 76
Lines 3505 3507 +2
==========================================
+ Hits 3071 3072 +1
- Misses 434 435 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cli/README.md
Outdated
| HOST_EXPORT_ROOT_DIR=../projects/configs | ||
| HOST_EXPORT_ROOT_DIR_MOUNT=./projects/configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could remove these variables and require that the projects/exports folder is always in f"{PIXL_ROOT}/projects/exports"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun! If I don't specify any of them in production, will they still work? I think we're fine to have a drop in coverage
Yep it should do, so long as PIXL is installed in editable mode (I tested this locally by deleting these vars from |
Description
Fixes #318 : Update PIXL CLI so that it can be installed in non-editable mode
add optional environment variables:
PIXL_ROOT: path to directory containingdocker-compose.ymlfile andprojects/configsfolder, either absolute or relative to the.envfileHOST_EXPORT_ROOT_DIR: path on host to export directory, either absolute or relative to the.envfileHOST_EXPORT_ROOT_DIR_MOUNT: path on host to export directory, either absolute or relative to thedocker-compose.ymlfile.envfile is in a different directory to thedocker-compose.ymlfile (which it is for the system tests).add docs on installing and running PIXL CLI in non-editable mode
add environment variables so the system tests can be run in non-editable mode
run the system tests in non-editable mode in CI
Type of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.squash and merge