adding the admission type to the visit table #106

skeating · 2025-08-10T14:17:54Z

Addresses #103

This reverts commit 567f6d9.

Adds functionality to extract and utilize the admission type information from the PV1 segment of HL7 messages. This includes defining a getter method and adding a unit test to verify the correct extraction of the admission type value..

…atd message factory

thompson318 · 2025-08-12T14:54:23Z

hl7-reader/src/main/java/uk/ac/ucl/rits/inform/datasources/ids/AdtMessageFactory.java

            case "A01":
                AdmitPatient admitPatient = new AdmitPatient();
                admitPatient.setAdmissionDateTime(InterchangeValue.buildFromHl7(pv1Wrap.getAdmissionDateTime()));
+                admitPatient.setAdmissionType(InterchangeValue.buildFromHl7(pv1Wrap.getAdmissionType()));


I'm not sure if we need to do this for all message types.

Yeah good question, if we only do it here then should remove from the generic ADT message.

…ller

stefpiatek

Looking good, will also need changes in emap core and the database to then save this information

stefpiatek · 2025-08-13T15:11:39Z

emap-interchange/src/main/java/uk/ac/ucl/rits/inform/interchange/adt/AdtMessage.java

    private InterchangeValue<String> patientTitle = InterchangeValue.unknown();
    private InterchangeValue<String> patientZipOrPostalCode = InterchangeValue.unknown();

+    private InterchangeValue<String> admissionType = InterchangeValue.unknown();


if the intention is to only have this in an admission message then we should remove it from here (or if its for all ADT, then we should remove it from AdmitPatient).

stefpiatek · 2025-08-13T15:13:14Z

hl7-reader/src/main/java/uk/ac/ucl/rits/inform/datasources/ids/AdtMessageFactory.java

            case "A01":
                AdmitPatient admitPatient = new AdmitPatient();
                admitPatient.setAdmissionDateTime(InterchangeValue.buildFromHl7(pv1Wrap.getAdmissionDateTime()));
+                admitPatient.setAdmissionType(InterchangeValue.buildFromHl7(pv1Wrap.getAdmissionType()));


Yeah good question, if we only do it here then should remove from the generic ADT message.

…ion_type

thompson318 · 2025-09-24T09:09:20Z

PR checklist

Default guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)

From the UCLH data science desktop, a validation run has been set off
Check that content that reveals Epic IP (eg. Clarity/Caboodle queries) has not been checked into a public repo.
load times
in UCL teams has been populated with the run information
During the run, glowroot has been checked for any queries which are taking a substantial proportion of the
total processing time. This can be useful to identify indexes that are required.
After the run, look for any unexpected errors in the etl_per_message_logging table, the error_search.sql file
on the shared drive can be used for this \\sharefs6\UCLH6\EMAP\Shared\EmapSqlScripts\devops\error_search.sql.
Create an issue if you find an unexpected exception and is not related to the changes you've made, otherwise
fix them!
After the run, populate the end time in
load times
Let Aasiyah know about the completed validation and give her information on the changes and where to start
with the validation
Check validation report and give any feedback to Aasiyah if there are any changes needed on her side,
iterate on getting the validation to match at least 99% (validation and emap code).

…age" This reverts commit 3d7d5aa.

thompson318 · 2025-09-25T09:00:37Z

running error_search.sql results in 15 errors (all the same)
could not execute statement; SQL [n/a]; nested exception is org.hibernate.exception.DataException: could not execute statement uk.ac.ucl.rits.inform.interchange.lab.LabOrderMsg

I ran the query on star_b to get a baseline, and observed the same error message there, so will raise a separate issue. #117

stefpiatek · 2025-09-25T10:14:14Z

Yeah as long as we're not introducing a new error with that change then that's fine.

skeating · 2025-10-30T12:20:52Z

NOTE THIS HAS BEEN MERGED INTO test_branch_zella

skeating and others added 6 commits August 10, 2025 14:17

add admission type to interchange

deb2c83

add tests for admission type

567f6d9

Revert "add tests for admission type"

e0b5d52

This reverts commit 567f6d9.

Adds admission type to PV1 segment parsing

a1141cd

Adds functionality to extract and utilize the admission type information from the PV1 segment of HL7 messages. This includes defining a getter method and adding a unit test to verify the correct extraction of the admission type value..

fixed check style

5f5d6ad

Fixes infinate loop in hl7 parser and adds get admission type to the …

9bfe53f

…atd message factory

thompson318 reviewed Aug 12, 2025

View reviewed changes

thompson318 added 5 commits August 12, 2025 16:59

Added test (failing) for emap star data sink

351b16b

Updated HL7 test message to match test

6814fc3

Add admission type to A01 message for test

e2c45dc

Add admission type to hospital visit schema

ee84638

added admission type to admitpatient message and adder to VisitContro…

4784d9d

…ller

stefpiatek reviewed Aug 13, 2025

View reviewed changes

skeating and others added 3 commits August 28, 2025 10:28

Merge remote-tracking branch 'origin/develop' into feature/add_admiss…

6841a46

…ion_type

See what happens if we remove admissiontype from generic message

3d7d5aa

Merge branch 'develop' into feature/add_admission_type

26d2fee

Revert "See what happens if we remove admissiontype from generic mess…

d748f9c

…age" This reverts commit 3d7d5aa.

thompson318 added 2 commits October 1, 2025 16:53

Try adding admission type to other message types

60cbc3f

Update adt message yaml to reflect that they now contain admission type

43a408a

thompson318 marked this pull request as ready for review October 6, 2025 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adding the admission type to the visit table #106

adding the admission type to the visit table #106

Uh oh!

skeating commented Aug 10, 2025 •

edited by thompson318

Loading

Uh oh!

thompson318 Aug 12, 2025

Uh oh!

stefpiatek Aug 13, 2025

Uh oh!

stefpiatek left a comment

Uh oh!

stefpiatek Aug 13, 2025

Uh oh!

stefpiatek Aug 13, 2025

Uh oh!

thompson318 commented Sep 24, 2025

Uh oh!

thompson318 commented Sep 25, 2025 •

edited

Loading

Uh oh!

stefpiatek commented Sep 25, 2025

Uh oh!

skeating commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adding the admission type to the visit table #106

Are you sure you want to change the base?

adding the admission type to the visit table #106

Uh oh!

Conversation

skeating commented Aug 10, 2025 • edited by thompson318 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thompson318 Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

stefpiatek Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

stefpiatek left a comment

Choose a reason for hiding this comment

Uh oh!

stefpiatek Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

stefpiatek Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

thompson318 commented Sep 24, 2025

PR checklist

Uh oh!

thompson318 commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefpiatek commented Sep 25, 2025

Uh oh!

skeating commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skeating commented Aug 10, 2025 •

edited by thompson318

Loading

thompson318 commented Sep 25, 2025 •

edited

Loading