Cleaning up README and adding some missing info#1
Open
nabeelre wants to merge 2 commits intoSAGUARO-MMA:masterfrom
Open
Cleaning up README and adding some missing info#1nabeelre wants to merge 2 commits intoSAGUARO-MMA:masterfrom
nabeelre wants to merge 2 commits intoSAGUARO-MMA:masterfrom
Conversation
Author
|
@swyatt7 does this look good to merge? It's only minor changes to the README which was missing some parameters for the requests |
swyatt7
approved these changes
May 1, 2025
Contributor
swyatt7
left a comment
swyatt7
left a comment
There was a problem hiding this comment.
Yeah this looks good to me.
maybe @ms1228 or @griffin-h should give it a read through as well before it is merged?
The formatting looks better for sure. Can someone just submit that observation as a test and make sure everything gets piped through correctly? We should have done this for the original version too, but maybe we didn't. |
Author
|
I unfortunately don't have an MMIRS allocation this term to test with, but I've verified the Binospec payload and fields |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.