Conversation
…hrefs for clarity and consistency; add new acts and resolutions for the 5th Assembly
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the Gazette data source and Gazette page UI to surface newly added/updated 5th Student Assembly Act documents, including enabling selection of year 2026 so Act No. 009-2526 is discoverable.
Changes:
- Updated
gazetteDocumentsentries for 5th Student Assembly Acts (including adding Acts 008 and 009 and updating links/metadata). - Added 2026 to the Gazette page year dropdown options (mobile + desktop).
- Reformatted/standardized quotes and layout in the Gazette page component.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/data/gazette-documents.ts |
Updates the Gazette document index with new/edited 5th Student Assembly act entries and links. |
src/components/pages/gazette-page.tsx |
Adds 2026 to the year filter dropdown and applies formatting/quote consistency updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| actNumber: 6, | ||
| year: 2025, | ||
| date: new Date("2025-08-09"), | ||
| href: "/documents/gazette-documents/5th-student-assembly/bills/SAMAHAN Act No. 006-2526 _ An Act Establishing the SAMAHAN Students Needs and Services (SNSD) Department.pdf", |
There was a problem hiding this comment.
The ACT 006 entry links to a very long, punctuation-heavy filename. The repo already contains a shorter, normalized duplicate PDF for this act (same directory, simpler name), so pointing the href at the normalized filename would make the URL less fragile and easier to maintain (especially when updating documents later).
| href: "/documents/gazette-documents/5th-student-assembly/bills/SAMAHAN Act No. 006-2526 _ An Act Establishing the SAMAHAN Students Needs and Services (SNSD) Department.pdf", | |
| href: "/documents/gazette-documents/5th-student-assembly/bills/samahan-act-006-2526.pdf", |
| actNumber: 7, | ||
| year: 2025, | ||
| date: new Date("2025-08-29"), | ||
| href: "/documents/gazette-documents/5th-student-assembly/bills/SAMAHAN Act No. 007-2526 _ AN ACT REPEALING THE 2024 STUDENT ASSEMBLY CODE OF LEGISLATIVE PROCEDURES AND IMPLEMENTING THE 2025 STUDENT ASSEMBLY CODE OF INTERNAL PROCEDURES.pdf", |
There was a problem hiding this comment.
Same as above for ACT 007: the href targets the long descriptive filename even though a shorter normalized PDF with the same act number exists in the same public folder. Prefer the normalized filename (or establish a consistent naming convention) to reduce the chance of typos/broken links when future updates happen.
| href: "/documents/gazette-documents/5th-student-assembly/bills/SAMAHAN Act No. 007-2526 _ AN ACT REPEALING THE 2024 STUDENT ASSEMBLY CODE OF LEGISLATIVE PROCEDURES AND IMPLEMENTING THE 2025 STUDENT ASSEMBLY CODE OF INTERNAL PROCEDURES.pdf", | |
| href: "/documents/gazette-documents/5th-student-assembly/bills/SAMAHAN Act No. 007-2526.pdf", |
| <label className="text-mainblue font-extrabold text-sm uppercase tracking-widest hidden md:block whitespace-nowrap"> | ||
| {label}<span className="font-['Arial']">:</span> | ||
| {label} | ||
| <span className="font-['Arial']">:</span> | ||
| </label> |
There was a problem hiding this comment.
This isn’t associated with the dropdown control (no htmlFor/id relationship), so it won’t be announced as a label by screen readers. Either associate it with the trigger button via htmlFor/id, or use a non-label element (e.g., ) if it’s purely visual.
| <div | ||
| key={option} | ||
| onClick={() => { | ||
| onChange(option); | ||
| setIsOpen(false); | ||
| }} | ||
| className="group flex items-center justify-between px-2 md:px-4 py-0.5 md:py-2 hover:bg-gray-300 cursor-pointer transition-colors text-mainblue font-medium" |
There was a problem hiding this comment.
Each option is rendered as a clickable
Added and Edited 5th Student Assembly Acts' PDF
Added 2026 in the Dropdown Section of the Gazette Page to review Act 9, which was made in 2026
Rest all Gazette Documents remain the same