Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
uses: actions/checkout@v6

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4

- name: Log in to Docker Registry
uses: docker/login-action@v3
Comment on lines 99 to 100
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update to use the latest version of docker/setup-buildx-action. However, consider also updating the docker/login-action from v3 to v4 for consistency and to benefit from the latest security improvements and bug fixes.

- name: Log in to Docker Registry
  uses: docker/login-action@v4

Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
ls -la dist/

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4

- name: Log in to Docker Registry
uses: docker/login-action@v3
Comment on lines 152 to 153
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same recommendation applies here - update docker/login-action to v4 to maintain consistency with the buildx-action update and ensure you're using the latest stable version.

- name: Log in to Docker Registry
  uses: docker/login-action@v4

Expand Down