Skip to content

Bump docker/login-action from 3 to 4 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −2
Open

Bump docker/login-action from 3 to 4 #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Log in to Docker Registry
uses: docker/login-action@v3
uses: docker/login-action@v4
with:
registry: ${{ secrets.DOCKER_REGISTRY_URL }}
username: ${{ secrets.DOCKER_REGISTRY_USERNAME }}
Comment on lines 97 to 103
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good practice updating the Docker login action to v4 for security and feature improvements. Consider also updating the docker/setup-buildx-action to the latest version for consistency:

uses: docker/setup-buildx-action@v4

This ensures all Docker-related actions are using their latest stable versions, which typically include security patches and performance improvements.

Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Log in to Docker Registry
uses: docker/login-action@v3
uses: docker/login-action@v4
with:
registry: ${{ secrets.DOCKER_REGISTRY_URL }}
username: ${{ secrets.DOCKER_REGISTRY_USERNAME }}
Comment on lines 152 to 156
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding error handling and validation for the Docker registry secrets. You could add a step to verify the secrets are present before attempting login:

- name: Validate Docker Registry Secrets
  run: |
    if [ -z "${{ secrets.DOCKER_REGISTRY_URL }}" ] || [ -z "${{ secrets.DOCKER_REGISTRY_USERNAME }}" ]; then
      echo "Error: Docker registry secrets are not configured"
      exit 1
    fi

- name: Log in to Docker Registry
  uses: docker/login-action@v4
  with:
    registry: ${{ secrets.DOCKER_REGISTRY_URL }}
    username: ${{ secrets.DOCKER_REGISTRY_USERNAME }}
    password: ${{ secrets.DOCKER_REGISTRY_PASSWORD }}

This provides better error messages and prevents silent failures when secrets are misconfigured.

Expand Down