Skip to content

Deploy gh-pages by remote trigger #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sapmachine
Choose a base branch
from
Open

Deploy gh-pages by remote trigger #2059

wants to merge 2 commits into from
+11 −8

Conversation

raeessap
Copy link

@raeessap raeessap commented Sep 8, 2025 •
edited by RealCLanger
Loading

TGSAPJVM-5744

fixes #1930

@SapMachine
Copy link
Member

Hello @raeessap, I'm sorry, this pull request doesn't meet the expectations. The pull request description has an invalid format. Please have a look at https://github.com/SAP/SapMachine/wiki/Formal-Requirements-of-Pull-Requests .

@skateball
Copy link
Contributor

Why have the identical contant twice? to me here should a minimalistic page "This page moved to sapmachine.io"

@RealCLanger
Copy link
Member

Why have the identical contant twice? to me here should a minimalistic page "This page moved to sapmachine.io"

We keep it for compatibility reasons because it contains some URL endpoints that are important in some scenarios (e.g. buildpacks etc.). Yes, we could at least have a minimalistic entry page but didn't do the effort yet. The idea is to turn off this edition of the page after a quite long rampdown period. Maybe by the end of 2026.

RealCLanger
RealCLanger approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready. I fixed the PR description text to make the CI accept it.

@SapMachine
Copy link
Member

Hello @raeessap, this pull request fulfills all formal requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealCLanger RealCLanger RealCLanger approved these changes

@skateball skateball Awaiting requested review from skateball

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom action to generate Github pages
4 participants
@raeessap @SapMachine @skateball @RealCLanger