feat: SpringAI integration in OpenAI #538

n-o-u-r-h-a-n · 2025-08-13T16:16:17Z

Context

AI/ai-sdk-java-backlog#179.

Implementation of Streaming for OpenAi in SpringAi was required to complete implementation of streamChatCompletion.

Feature scope:

Updating OpenAiChatModel Class.
Updating SpringAiOpenAiController Class.

Definition of Done

Functionality scope stated & covered
Tests cover the scope above
Error handling created / updated & covered by the tests above
~~Aligned changes with the JavaScript SDK~~
Documentation updated
Release notes updated

… 1.0.0 (GA Version) (#503)"

… AI 1.0.0 (GA Version) (#503)".

…AiService + their corresponding passed tests in SpringAiOpenAiTest class. Regarding the OpenAiChatModel class it was just formatting, nothing changed.

--> 4 methods in OpenAiChatCompletionRequest.java return only this now and other constructors other than main are removed for now.

…ringopenai # Conflicts: # core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java

CharlesDuboisSAP

release notes mentioning the new public API are lacking.

…' into chatcompletion-for-springopenai2 # Conflicts: # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java

… OpenAi Client.

docs/release_notes.md

Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java

foundation-models/openai/pom.xml

# Conflicts: # docs/release_notes.md

Jonas-Isr and others added 30 commits June 16, 2025 17:44

first draft

9ff262b

Align with docs

b14d70c

Codestyle

b32b999

Merge branch 'main' into agent-workflow-examples

32d1bb2

Merge branch 'main' into agent-workflow-examples

5720581

Merge branch 'main' into agent-workflow-examples

64c8b0e

Merge branch 'main' into agent-workflow-examples

98ab1af

feat: [OpenAI] Spring AI integration

0e59667

test

71898c5

Merge branch 'agent-workflow-examples' into openai-springai

b056414

test

025eba1

Merge branch 'agent-workflow-examples' into openai-springai

d402c64

Merge branch 'main' into openai-springai

7ed6baa

Fixing errors in OpenAiChatOptions according to "Upgrade to Spring AI…

3b0273b

… 1.0.0 (GA Version) (#503)"

Fixing errors in OpenAiChatOptions according to "Upgrade to Spring AI…

8c2a638

… 1.0.0 (GA Version) (#503)"

Fixing SpringAiAgenticWorkflowService according to "Upgrade to Spring…

8eb5459

… AI 1.0.0 (GA Version) (#503)".

Implementation of completion and streamChatCompletion in SpringAiOpen…

ab1f795

…AiService + their corresponding passed tests in SpringAiOpenAiTest class. Regarding the OpenAiChatModel class it was just formatting, nothing changed.

Removing a comment

9d4bdcd

Removing a comment

72198d9

Chat Memory test working.

88904c8

Formatting for SpringAiOpenAiService.

47d1bc0

Removing unneccessary imports in SpringAiOpenAiService.

443e464

Updating the toOpenAiRequest in OpenAiChatModel.java.

00ba4ad

Implementing the new approach

55c85d9

--> 4 methods in OpenAiChatCompletionRequest.java return only this now and other constructors other than main are removed for now.

Editing the approach.

56cda93

Fix compilation and format and annotations and javadoc

0183c83

Merge remote-tracking branch 'origin/main' into chatcompletion-for-sp…

02d5f54

…ringopenai # Conflicts: # core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

Remove unrelated code

ee94941

implementation hint

dec85d6

Formatting

d99dc0e

newtork reviewed Aug 14, 2025

View reviewed changes

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java Outdated Show resolved Hide resolved

CharlesDuboisSAP changed the title ~~feat: Implementing Streaming for OpenAi in SpringAi~~ feat: SpringAI integration in OpenAI Aug 14, 2025

CharlesDuboisSAP self-assigned this Aug 14, 2025

rpanackal reviewed Aug 14, 2025

View reviewed changes

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java Outdated Show resolved Hide resolved

CharlesDuboisSAP and others added 3 commits August 15, 2025 10:30

Merge branch 'main' into chatcompletion-for-springopenai2

9b2b5bf

Added more options and metadata

f9a719e

Formatting

074d794

CharlesDuboisSAP reviewed Aug 15, 2025

View reviewed changes

n-o-u-r-h-a-n added 5 commits August 15, 2025 16:04

Fixing Format/Style (Minor).

554e45a

Merge remote-tracking branch 'origin/chatcompletion-for-springopenai2…

47ca557

…' into chatcompletion-for-springopenai2 # Conflicts: # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java

Merge branch 'main' into chatcompletion-for-springopenai2

43bc1fc

Fixing Format/Style (Minor).

7ee82a7

Updating the Release notes according to integrating SpringAI with our…

50043e0

… OpenAi Client.

CharlesDuboisSAP reviewed Aug 18, 2025

View reviewed changes

docs/release_notes.md Outdated Show resolved Hide resolved

n-o-u-r-h-a-n and others added 4 commits August 18, 2025 11:38

Update docs/release_notes.md

c9fb23f

Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>

Handling JsonProcessingException

6abcdce

Merge branch 'main' into chatcompletion-for-springopenai2

2e7860c

Handling JsonProcessingException

613d0df

CharlesDuboisSAP reviewed Aug 18, 2025

View reviewed changes

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java Outdated Show resolved Hide resolved

n-o-u-r-h-a-n and others added 2 commits August 18, 2025 12:32

Handling JsonProcessingException

1154537

Formatting

bfe6202

CharlesDuboisSAP previously approved these changes Aug 18, 2025

View reviewed changes

newtork reviewed Aug 19, 2025

View reviewed changes

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java Outdated Show resolved Hide resolved

newtork reviewed Aug 19, 2025

View reviewed changes

foundation-models/openai/pom.xml Show resolved Hide resolved

CharlesDuboisSAP added 2 commits August 19, 2025 12:36

Merge branch 'main' into chatcompletion-for-springopenai2

f91d32b

# Conflicts: # docs/release_notes.md

protected extractOptions

3b5bad8

CharlesDuboisSAP dismissed their stale review via 3b5bad8 August 19, 2025 10:43

newtork approved these changes Aug 19, 2025

View reviewed changes

n-o-u-r-h-a-n merged commit 9605b66 into main Aug 19, 2025
7 checks passed

n-o-u-r-h-a-n deleted the chatcompletion-for-springopenai2 branch August 19, 2025 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: SpringAI integration in OpenAI #538

feat: SpringAI integration in OpenAI #538

Uh oh!

n-o-u-r-h-a-n commented Aug 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

CharlesDuboisSAP left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: SpringAI integration in OpenAI #538

feat: SpringAI integration in OpenAI #538

Uh oh!

Conversation

n-o-u-r-h-a-n commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Feature scope:

Definition of Done

Uh oh!

Uh oh!

Uh oh!

CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

n-o-u-r-h-a-n commented Aug 13, 2025 •

edited

Loading