Skip to content

feat: Using Prompt Registry Templates in SpringAI #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 22, 2025
Merged

feat: Using Prompt Registry Templates in SpringAI #549

merged 23 commits into from
Aug 22, 2025

Conversation

n-o-u-r-h-a-n
Copy link
Contributor

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Aug 18, 2025 •
edited
Loading

Context

AI/ai-sdk-java-backlog#275.

Being able to use Prompt Registry Templates in Spring AI with chatmemory and inputparams in response to the customer (Joule Integration).

Feature scope:

  • Adding OrchestrationSpringUtil Class with utility method which returns a prompt when given input parameters and a template name.
  • Adding a service method for that utility in the SpringAiOrchestrationService class.
    • Testing it using a test made in SpringAiOrchestrationTest class.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

CharlesDuboisSAP
CharlesDuboisSAP reviewed Aug 18, 2025
View reviewed changes
CharlesDuboisSAP
CharlesDuboisSAP reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't forget the index.html, release notes and documentation

n-o-u-r-h-a-n and others added 12 commits August 20, 2025 15:45
@n-o-u-r-h-a-n
Doing Unit Test and moving method to Prompt Registry.
2653c1f
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/Using-Prompt-Registry-Templates-…
58b2bbe 
…in-SpringAi' into Using-Prompt-Registry-Templates-in-SpringAi
@bot-sdk-js
Formatting
1ec76f6
@n-o-u-r-h-a-n
Doing Unit Test and moving method to Prompt Registry.
7148907
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/Using-Prompt-Registry-Templates-…
173481a 
…in-SpringAi' into Using-Prompt-Registry-Templates-in-SpringAi

# Conflicts:
#	core-services/prompt-registry/src/test/java/com/sap/ai/sdk/prompt/registry/spring/SpringAiConverterTest.java
#	sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/PromptRegistryController.java
#	sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java
@bot-sdk-js
Formatting
090872d
@n-o-u-r-h-a-n
Fixing Coverage.
b446dc2
@bot-sdk-js
Formatting
c935907
@n-o-u-r-h-a-n
Format
8cb9900
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/Using-Prompt-Registry-Templates-…
77775c7 
…in-SpringAi' into Using-Prompt-Registry-Templates-in-SpringAi
@n-o-u-r-h-a-n
Fixing Javadoc
0b93e28
@n-o-u-r-h-a-n
Reverting
4622ca0
@n-o-u-r-h-a-n n-o-u-r-h-a-n requested a review from newtork August 21, 2025 10:37
@n-o-u-r-h-a-n n-o-u-r-h-a-n mentioned this pull request Aug 21, 2025
Open
@n-o-u-r-h-a-n n-o-u-r-h-a-n merged commit d651e8c into main Aug 22, 2025
9 checks passed
@n-o-u-r-h-a-n n-o-u-r-h-a-n deleted the Using-Prompt-Registry-Templates-in-SpringAi branch August 22, 2025 09:57
newtork
newtork reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newtork newtork newtork left review comments

@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n-o-u-r-h-a-n @newtork @CharlesDuboisSAP @bot-sdk-js