Skip to content

FIx Github Workflow Test Failures #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarstenSchnitter merged 2 commits into from
Oct 30, 2025
Merged

FIx Github Workflow Test Failures #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
129e7fa
Improve MDC CleanUp
KarstenSchnitter Oct 30, 2025
0c50543
Fix Maven Configuration
KarstenSchnitter Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/maven-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,29 @@ on:

jobs:
build-main:
if: github.base_ref == 'release-3'
if: github.base_ref == 'main'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '11'
- name: Clean with Maven
run: mvn clean
java-version: '17'
- name: Build with Maven
run: mvn verify

build-release-4:
if: github.base_ref == 'main'
run: mvn -B -ntp -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn clean verify
build-release-3:
if: github.base_ref == 'release-3'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '17'
java-version: '11'
- name: Clean with Maven
run: mvn clean
- name: Build with Maven
run: mvn clean verify
run:
run: mvn -B -ntp -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn verify
4 changes: 3 additions & 1 deletion ...ort-logback/src/test/java/com/sap/hcp/cf/logback/filter/CustomLoggingTurboFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import ch.qos.logback.core.spi.FilterReply;
import com.sap.hcp.cf.logging.common.helper.DynamicLogLevelHelper;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
import org.slf4j.MDC;
Expand All @@ -24,8 +25,9 @@ public class CustomLoggingTurboFilterTest {

private final Logger logger = Mockito.mock(Logger.class);

@BeforeEach
@AfterEach
public void teardown() {
public void clear() {
MDC.clear();
}

Expand Down