Skip to content

feat: Offer CircuitBreakerConfiguration in DestinationService DestinationLoader builder #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Offer CircuitBreakerConfiguration in DestinationService DestinationLoader builder #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions ...ervice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,8 @@ public static final class Builder
@Nullable
private TimeLimiterConfiguration timeLimiterConfiguration = null;
@Nullable
private CircuitBreakerConfiguration circuitBreakerConfiguration = null;
@Nullable
private String providerTenantId;

/**
Expand All @@ -938,6 +940,23 @@ public Builder withTimeLimiterConfiguration( @Nonnull final TimeLimiterConfigura
return this;
}

/**
* Create instance applying the given circuit breaker when retrieving destinations.
*
* @param circuitBreakerConfiguration
* The circuit-breaker configuration to be applied for the request. Use
* {@code TimeLimiterConfiguration.disabled()} to diable the circuit-breaker.
* @return The builder itself.
* @since 5.25.0
*/
@Nonnull
public Builder withCircuitBreakerConfiguration(
@Nonnull final CircuitBreakerConfiguration circuitBreakerConfiguration )
{
this.circuitBreakerConfiguration = circuitBreakerConfiguration;
return this;
}

@Nonnull
Builder withProviderTenant( @Nonnull final Tenant providerTenant )
{
Expand All @@ -956,10 +975,12 @@ public DestinationService build()
{
final TimeLimiterConfiguration timeLimiter =
timeLimiterConfiguration != null ? timeLimiterConfiguration : DEFAULT_TIME_LIMITER;
final CircuitBreakerConfiguration circuitBreaker =
circuitBreakerConfiguration != null ? circuitBreakerConfiguration : DEFAULT_SINGLE_DEST_CIRCUIT_BREAKER;
return new DestinationService(
new DestinationServiceAdapter(null, null, providerTenantId),
createResilienceConfiguration("singleDestResilience", timeLimiter, DEFAULT_SINGLE_DEST_CIRCUIT_BREAKER),
createResilienceConfiguration("allDestResilience", timeLimiter, DEFAULT_ALL_DEST_CIRCUIT_BREAKER));
createResilienceConfiguration("singleDestResilience", timeLimiter, circuitBreaker),
createResilienceConfiguration("allDestResilience", timeLimiter, circuitBreaker));
}
}
}