add basic testDelete for Subaccount #146
Conversation
vickysuch
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
| }, | ||
| }, | ||
| want: want{ | ||
| err: errors.New("Deletion Pending: Current status: Deleting"), |
There was a problem hiding this comment.
I tripped over that one during our call.
It actually looks like there is an implementation error which returns an error here always in the first reconcile run. In the next one it will resolve itself. I have actually seen this error occasionally in my cluster, but thought its an API hickup since it resolved itself.
So yes your testing here is great, but can you create a follow up issue to fix the implementation and maybe put a comment here that this is actually wrong and requires fixing?
There was a problem hiding this comment.
ah ok sure will do so, created an issue here: #155, was also wondering whats the reason to return error
| @@ -6,6 +6,7 @@ import ( | |||
|
|
|||
| // ContainsError While testing there is no point in mimicking wrapped error hierarchies, but we do want to distinguish check | |||
| // whether an error is part of the stacktrace | |||
| // when error message itself contains :, the split contains logic is not enough, add compare of error message itself | |||
There was a problem hiding this comment.
Yes actually I think with newer go versions some error.Is function has been introduced that makes this manually check pointless, but thats good enough for now as well.
vickysuch
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
vickysuch
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
vickysuch
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
Relates to: #83
Adds Testing for Subaccount controller.