fixed compatability with CTF volume reconstructed by WARP#73
Closed
alncat wants to merge 1 commit intoSBC-Utrecht:masterfrom
Closed
fixed compatability with CTF volume reconstructed by WARP#73alncat wants to merge 1 commit intoSBC-Utrecht:masterfrom
alncat wants to merge 1 commit intoSBC-Utrecht:masterfrom
Conversation
Contributor
Author
|
Hi @sroet, just checking the status of this PR. Do you have any time to review it? |
Collaborator
|
Hey @alncat, Thanks for proposing a fix and the reminder ping. About the code, it is mentioned in the docstring of the class on line 1548-1553: class Wedge3dCTF(PyTomClass):
"""
This is a class to allow pytom running with 3d ctf volumes from warp or relion as the missing wedge.
Class handles reading of the wedge file from disk. Before being able to use the 3d ctf from warp it
first needs to be converted to have the z axis as the reduced fourier space dimension.
"""This class is for both WARP and RELION files, however for WARP files the user needs to make the z-axis the reduced fourier dimension. I think the code is working as intended and this would break both our internal representation and the reading of RELION files. I will close this PR, but feel free to reopen/discuss if you don't agree with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear PyTOM developers,
I noticed that there is a small bug when performing local alignment using the subtomogram and CTF reconstructed by WARP. The CTF volume reconstructed by WARP is of size (D//2+1, D, D) if the subtomogram is of size (D, D, D), i..e, the reduced axis is 0. Therefore, we should expand fourier transforms from reduced representation to full representation by specifying the reduced axis as 0. Hence, I made the modification,
Best Regards,
Zhenwei