Import & Export rotation delta for animation.#3
Open
mwl4 wants to merge 1 commit intoSCSSoftware:masterfrom
Open
Import & Export rotation delta for animation.#3mwl4 wants to merge 1 commit intoSCSSoftware:masterfrom
mwl4 wants to merge 1 commit intoSCSSoftware:masterfrom
Conversation
simon50keda
added a commit
that referenced
this pull request
Jun 6, 2022
Author
|
@simon50keda Can it be merged? |
Contributor
|
We don't merge pull requests since this is not main development repo. But will consider incorporation of this commit in the main repo in future updates, thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified with pia2pma tool.
The only problem with given changes is that it does not produce Euler rotation, so in Blender you have to switch to Quaternion transform for Pose, otherwise you will not see visual representation. The same applies to bone animations, where both euler and quaternion is generated and issue is gone.
There are corresponding changes to ConverterPIX to support this feature: mwl4/ConverterPIX@fc57807
(will be merged as soon as this one will be merged).